Skip to content

fix: drop stale obs/updates in rfced sync #10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-richards merged 2 commits into from
Mar 13, 2026
Merged

fix: drop stale obs/updates in rfced sync #10543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b60d6f8
fix: drop stale obs/updates in rfced sync
jennifer-richards Mar 13, 2026
986e2f5
refactor: partial revert, orig was safer
jennifer-richards Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 50 additions & 23 deletions ietf/sync/rfceditor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,43 +636,70 @@ def update_docs_from_rfc_index(
)
rfc_published = True

def parse_relation_list(l):
res = []
for x in l:
for a in Document.objects.filter(name=x.lower(), type_id="rfc"):
if a not in res:
res.append(a)
return res

for x in parse_relation_list(obsoletes):
if not RelatedDocument.objects.filter(
source=doc, target=x, relationship=relationship_obsoletes
def parse_relation_list(rel_list: list[str]) -> list[Document]:
return list(
Document.objects.filter(
name__in=[name.strip().lower() for name in rel_list],
type_id="rfc"
)
)

# Create missing obsoletes relations
docs_this_obsoletes = parse_relation_list(obsoletes)
for obs_doc in docs_this_obsoletes:
if not doc.relateddocument_set.filter(
target=obs_doc, relationship=relationship_obsoletes
):
r = RelatedDocument.objects.create(
source=doc, target=x, relationship=relationship_obsoletes
r = doc.relateddocument_set.create(
target=obs_doc, relationship=relationship_obsoletes
)
rfc_changes.append(
"created {rel_name} relation between {src_name} and {tgt_name}".format(
"created {rel_name} relation between {src} and {tgt}".format(
rel_name=r.relationship.name.lower(),
src_name=prettify_std_name(r.source.name),
tgt_name=prettify_std_name(r.target.name),
src=prettify_std_name(r.source.name),
tgt=prettify_std_name(r.target.name),
)
)
# Remove stale obsoletes relations
for r in doc.relateddocument_set.filter(
relationship=relationship_obsoletes
).exclude(target_id__in=[d.pk for d in docs_this_obsoletes]):
r.delete()
rfc_changes.append(
"removed {rel_name} relation between {src} and {tgt}".format(
rel_name=r.relationship.name.lower(),
src=prettify_std_name(r.source.name),
tgt=prettify_std_name(r.target.name),
)
)

for x in parse_relation_list(updates):
docs_this_updates = parse_relation_list(updates)
for upd_doc in docs_this_updates:
if not RelatedDocument.objects.filter(
source=doc, target=x, relationship=relationship_updates
source=doc, target=upd_doc, relationship=relationship_updates
):
r = RelatedDocument.objects.create(
source=doc, target=x, relationship=relationship_updates
r = doc.relateddocument_set.create(
target=upd_doc, relationship=relationship_updates
)
rfc_changes.append(
"created {rel_name} relation between {src_name} and {tgt_name}".format(
"created {rel_name} relation between {src} and {tgt}".format(
rel_name=r.relationship.name.lower(),
src_name=prettify_std_name(r.source.name),
tgt_name=prettify_std_name(r.target.name),
src=prettify_std_name(r.source.name),
tgt=prettify_std_name(r.target.name),
)
)
# Remove stale updates relations
for r in doc.relateddocument_set.filter(
relationship=relationship_updates
).exclude(target_id__in=[d.pk for d in docs_this_updates]):
r.delete()
rfc_changes.append(
"removed {rel_name} relation between {src} and {tgt}".format(
rel_name=r.relationship.name.lower(),
src=prettify_std_name(r.source.name),
tgt=prettify_std_name(r.target.name),
)
)

if also:
# recondition also to have proper subseries document names:
Expand Down
Loading