fix: blank not null for StoredObject doc_name/doc_rev - #10400
Merged
jennifer-richards merged 4 commits intoFeb 12, 2026
Merged
Conversation
rjsparks
reviewed
Feb 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/storedobj #10400 +/- ##
=================================================
Coverage ? 88.36%
=================================================
Files ? 325
Lines ? 43644
Branches ? 0
=================================================
Hits ? 38566
Misses ? 5078
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Migration in dev takes about 7 seconds total (with about 4.7 seconds of that in migration system overhead) |
jennifer-richards
marked this pull request as ready for review
February 12, 2026 01:43
rjsparks
approved these changes
Feb 12, 2026
jennifer-richards
merged commit Feb 12, 2026
a9c35f9
into
ietf-tools:feat/storedobj
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows matching a doc via
StoredObject.objects.filter(doc_name=doc.name, doc_rev=doc.rev), which doesn't work if those fields areNone. Will want to confirm that the migration is not slow in staging.Todo before promoting from draft PR:
StoredObjectdoes not need explicit defaults for those fieldsIf / when this is merged, we can roll back #10401.