refactor: authors() -> author_persons()#10237
Merged
rjsparks merged 5 commits intoietf-tools:feat/rpc-apifrom Jan 9, 2026
Merged
refactor: authors() -> author_persons()#10237rjsparks merged 5 commits intoietf-tools:feat/rpc-apifrom
rjsparks merged 5 commits intoietf-tools:feat/rpc-apifrom
Conversation
rjsparks
requested changes
Jan 9, 2026
| authors_qs = self.rfcauthor_set.filter(person__isnull=False) | ||
| else: | ||
| authors_qs = self.documentauthor_set.all() | ||
| print(f"nyah: {authors_qs.count()}") |
rjsparks
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the
DocumentInfo.authors()method toauthor_persons()and formalize that it omits any authors that do not have aPerson. Refactor code using this. In most cases this is just using the new method, but in a couple templates I've switched to theauthor_persons_or_names()method. That's likely a moot distinction for now, but looks ahead to when we eventually unify the author models between drafts and RFCs.