Skip to content

chore: order is_auth'd middleware correctly#10225

Merged
rjsparks merged 1 commit intoietf-tools:mainfrom
jennifer-richards:auth-flag-logging
Jan 16, 2026
Merged

chore: order is_auth'd middleware correctly#10225
rjsparks merged 1 commit intoietf-tools:mainfrom
jennifer-richards:auth-flag-logging

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Needs to be earlier than ConditionalGetMiddleware or the flag will not be set for 304 responses.

Needs to be earlier than ConditionalGetMiddleware or the flag
will not be set for 304 responses.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (c0115c9) to head (3ab638c).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10225   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files         317      317           
  Lines       42544    42544           
=======================================
+ Hits        37682    37684    +2     
+ Misses       4862     4860    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks rjsparks merged commit 4aeb36e into ietf-tools:main Jan 16, 2026
15 of 16 checks passed
@jennifer-richards jennifer-richards deleted the auth-flag-logging branch January 16, 2026 20:49
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants