feat: better author edit via Rfc update API#10052
Merged
jennifer-richards merged 14 commits intoietf-tools:feat/rpc-apifrom Dec 4, 2025
Merged
feat: better author edit via Rfc update API#10052jennifer-richards merged 14 commits intoietf-tools:feat/rpc-apifrom
jennifer-richards merged 14 commits intoietf-tools:feat/rpc-apifrom
Conversation
This can perhaps go away entirely
rjsparks
approved these changes
Dec 4, 2025
rudimatz
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a proper update algorithm to #10048 and can either replace that PR or be updated / merged afterwards.
Instead of doing a bulk drop and replace when a new set of authors comes in, uses an algorithm based on the existing
update_documentauthors()method to adjust existing author records and create reasonably human readable logs. Treats author records with the same Person as equivalent and, if there is no Person, uses equaltitlepage_name. This will result in some silly logs related to organization authors but these are rare. This could be improved a bit without extraordinary effort, but the returns seem marginal to me.This deals somewhat transparently with an upgrade from DocumentAuthor to RfcAuthors for an RFC. It does not add an explicit flag that the underlying models have changed, it just notes changes in the data, though in almost every case the name is changed. For this purpose,
documentauthor.person.plain_name()is used as the stand-in fortitlepage_namewhen deciding how to describe the change. This matches up with what we've been presenting at red and with the display on the datatracker document page.Also, the event messages translate the internal
titlepage_nameto "name" in the change descriptions. That is, if "Jennifer Richards" is changed to "J. Richards", the log will look like "changed name from 'Jennifer Richards' to 'J. Richards'".Also: this doesn't populate
RfcAuthor.emailat all. It doesn't remove it from the model either, it just leaves it alone for now.