Skip to content

feat: better author edit via Rfc update API#10052

Merged
jennifer-richards merged 14 commits intoietf-tools:feat/rpc-apifrom
jennifer-richards:rfcauthor-docevents
Dec 4, 2025
Merged

feat: better author edit via Rfc update API#10052
jennifer-richards merged 14 commits intoietf-tools:feat/rpc-apifrom
jennifer-richards:rfcauthor-docevents

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards commented Dec 3, 2025

This adds a proper update algorithm to #10048 and can either replace that PR or be updated / merged afterwards.

Instead of doing a bulk drop and replace when a new set of authors comes in, uses an algorithm based on the existing update_documentauthors() method to adjust existing author records and create reasonably human readable logs. Treats author records with the same Person as equivalent and, if there is no Person, uses equal titlepage_name. This will result in some silly logs related to organization authors but these are rare. This could be improved a bit without extraordinary effort, but the returns seem marginal to me.

This deals somewhat transparently with an upgrade from DocumentAuthor to RfcAuthors for an RFC. It does not add an explicit flag that the underlying models have changed, it just notes changes in the data, though in almost every case the name is changed. For this purpose, documentauthor.person.plain_name() is used as the stand-in for titlepage_name when deciding how to describe the change. This matches up with what we've been presenting at red and with the display on the datatracker document page.

Also, the event messages translate the internal titlepage_name to "name" in the change descriptions. That is, if "Jennifer Richards" is changed to "J. Richards", the log will look like "changed name from 'Jennifer Richards' to 'J. Richards'".

Also: this doesn't populate RfcAuthor.email at all. It doesn't remove it from the model either, it just leaves it alone for now.

@jennifer-richards jennifer-richards changed the title feat: full RfcAuthor API implementation feat: better author edit via Rfc update API Dec 3, 2025
@jennifer-richards jennifer-richards merged commit cb0e107 into ietf-tools:feat/rpc-api Dec 4, 2025
2 checks passed
@jennifer-richards jennifer-richards deleted the rfcauthor-docevents branch December 4, 2025 19:52
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants