fix: Restyle references#10024
Conversation
This tries to make the HTML rendering look good, using the native bootstrap styling as much as I can be bothered to do for now.
This is a little hacky in that it relies on xml2rfc inserting `<dd class="break"></dd>` after each reference, but that seems to be something that we can rely on consistently across the series. This is, as far as I can tell, character-for-character identical to the placement used in xml2rfc's text generation output. I had to make a small tweak to the layout for regular definition lists as well, but that's fairly minor (it was missing an indent). See martinthomson/rfc-txt-html#13 for a discussion on the fix. Based on ietf-tools#10016, but this could be retargeted at main if that makes more sense.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10024 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.02%
==========================================
Files 317 317
Lines 42343 42387 +44
==========================================
+ Hits 37496 37530 +34
- Misses 4847 4857 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennifer-richards
left a comment
There was a problem hiding this comment.
Looks ok to me. I don't have a strong sense about whether relying on the <dd> from xml2rfc is a winning strategy for the long term, but as the existing styling options are preserved it seems mostly harmless.
That does hint at questions about proliferation of style options to support going forward but the count is still reasonable imo.
|
The |

This is a little hacky in that it relies on xml2rfc inserting
<dd class="break"></dd>after each reference, but that seems to besomething that we can rely on consistently across the series.
This is, as far as I can tell, character-for-character identical to the
placement used in xml2rfc's text generation output. I had to make a
small tweak to the layout for regular definition lists as well, but
that's fairly minor (it was missing an indent).
See martinthomson/rfc-txt-html#13 for a
discussion on the fix.
Stacked on #10016, but this could be retargeted at main if that makes more
sense.