Skip to content

feat: split unknown vs already published draft error #10011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-richards merged 1 commit into from
Nov 26, 2025
Merged

feat: split unknown vs already published draft error #10011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ietf/api/serializers_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,18 +335,22 @@ def create(self, validated_data):
type_id="draft",
name=draft_name,
rev=draft_rev,
).exclude(
states__type_id="draft",
states__slug="rfc",
).first()
if draft is None:
raise serializers.ValidationError(
{
"draft_name": "No such draft or draft already published as RFC",
"draft_rev": "No such draft or draft already published as RFC",
"draft_name": "No such draft",
"draft_rev": "No such draft",
},
code="invalid-draft"
)
elif draft.get_state_slug() == "rfc":
raise serializers.ValidationError(
{
"draft_name": "Draft already published as RFC",
},
code="already-published-draft",
)
defaults_from_draft = {
"ad": draft.ad,
"formal_languages": draft.formal_languages.all(),
Expand Down