Skip to content

AD milestones page crashes if any milestones have no due date #6641

@jennifer-richards

Description

@jennifer-richards

Describe the issue

The milestones view at /iesg/milestones/ throws a server error if there are GroupMilestone instances with null due fields in the display list. The error is

TypeError at /iesg/milestones/

'<' not supported between instances of 'NoneType' and 'NoneType'

Request Method: 	GET
Request URL: 	https://datatracker.ietf.org/iesg/milestones/
Django Version: 	4.2.6
Exception Type: 	TypeError
Exception Value: 	

'<' not supported between instances of 'NoneType' and 'NoneType'

Exception Location: 	/a/www/ietf-datatracker/11.14.0/ietf/iesg/views.py, line 529, in milestones_needing_review

The specific problem is that the sorting code for milestones assumes due is a valid sorting key. Filling in that field for the two milestones currently without it avoids this bug. The obvious fix is to apply the standard ordering on milestones (order, due, id) for the model rather than only due.

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions