Prevent the "discuss text not found" error

[ietf-svn-bot]

owner:rjsparks@nostrum.com resolution_fixed type_defect | by rjsparks@nostrum.com

---

It is currently possible to have a ballot marked discuss, but with no discuss object containing discuss text to back it up.

---

Issue migrated from trac:660 at 2022-03-04 01:49:37 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed priority from n/a to major

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com set resolution to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 6484874:

1. Restructured the position editing page to better integrate the defer button.
   Fixes bug Improve the layout of the edit-position form so that the actions that conplete the form are more intuitive #659

2. Copied the jquery-1.5.1.min.js library into /static/js/lib (from /static/js)
   because that's where the main document template was looking for it. There have
   probably been several problems since the change that left this dangling that
   showed up as things not behaving, but not as errors. The one that clued me in
   was the discuss text-box not being hidden when the position wasn't DISCUSS.
   They should all behave better now.

3. Added a django form validator to the discuss text field to not allow actions
   when the position is Discuss, but the discuss-text is empty.
   2 and 3 together fix bug Prevent the "discuss text not found" error #660

4. Added logic to the undefer fuction to put the document back on the previous
   telechat (if that hasn't already passed). That is, date1 from telechat dates,
   and not date2.
   Fixes bug Undefer should move a document back to the telechat it was deferred from #661

5. Changed the last_call_announcement generation function's template to include
   the abstracts from the document sets (which with modern usage means the abstract
   of the document) reflecting the IESGs decision of a few months back.
   Fixes bug Generate last call text should include the document set's abstracts #662

6. Removed the old tracker link from the document's main page
   Fixes bug Remove the button that links to the old IESG tracker #663

_M .
M ietf/idrfc/views_ballot.py
M ietf/templates/idrfc/last_call_announcement.txt
M ietf/templates/idrfc/undefer_ballot.html
M ietf/templates/idrfc/doc_tab_document.html
M ietf/templates/idrfc/edit_position.html
_M ietf/utils/draft.py
_M static/media
A + static/js/lib/jquery-1.5.1.min.js