Unreachable code in rfc-editor-index-updates

[ietf-svn-bot]

type_cleanup | by jennifer@painless-security.com

---

Near the bottom of ietf/bin/rfc-editor-index-updates, there is an unreachable block of code after an unconditional sys.exit(0). The code has been unreachable since 2016 based on the svn history. This should either be removed or some explanation of the situation should be added.

---

Issue migrated from trac:3491 at 2022-03-04 09:22:38 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to under_review

[ietf-svn-bot]

@rjsparks@nostrum.com edited the issue description

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

The code can be removed, but we should research whether the document relations are already getting appropriately updated as these posts happen.

[ietf-svn-bot]

@rjsparks@nostrum.com edited the issue description

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

bah - trac's entry form trapped me into a bad edit - fixup with this post:

If you remove the code before then, perhaps add a comment pointing back to this ticket until we resolve that question.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

From 11b5b8c:

Comment out unreachable code in rfc-editor-index-updates. Relates to #3491.

[larseggert]

Done?

[rjsparks]

Well, no.
The part about reassessing whether relations are built correctly is still an issue, but that's tracked elsewhere now.
The code in main is still present, uncommented, and unreachable:

datatracker/ietf/bin/rfc-editor-index-updates

Lines 89 to 110 in 5fc93bb

	sys.exit(0)
	# This can be called while processing a notifying POST from the RFC Editor
	# Spawn a child to sync the rfcs and calculate new reference relationships
	# so that the POST
	newpid = os.fork()
	if newpid == 0:
	try:
	pipe("%s -a %s %s" % (settings.RSYNC_BINARY,settings.RFC_TEXT_RSYNC_SOURCE,settings.RFC_PATH))
	for rfc in new_rfcs:
	rebuild_reference_relations(rfc)
	log("Updated references for %s"%rfc.canonical_name())
	except:
	subject = "Exception in updating references for new rfcs: %s : %s" % (sys.exc_info()[0],sys.exc_info()[1])
	msg = "%s\n%s\n----\n%s"%(sys.exc_info()[0],sys.exc_info()[1],traceback.format_tb(sys.exc_info()[2]))
	mail_admins(subject,msg,fail_silently=True)
	log(subject)
	os._exit(0)
	else:
	sys.exit(0)