Nomcom chair edit-members tool needs inspection

[ietf-svn-bot]

owner:jennifer@painless-security.com resolution_fixed type_defect | by rjsparks@nostrum.com

---

It appears that when the nomcom chair uses the edit-members view from the Chairs Tasks menu, unexpected things take place:

1. GroupEvents are not created, so there is no history of the resulting personnel change on the related /group/nomcom/history page.

2. Other roles are reset. Specifically when someone is listed as both a member and a liaison, and then removed as a member through this view, they are also removed as a liaison. This is likely similar to issues addressed in group edit form destroys roles #3253.

---

Issue migrated from trac:3376 at 2022-03-04 09:10:54 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to accepted

[ietf-svn-bot]

@jennifer@painless-security.com changed status from accepted to assigned

[ietf-svn-bot]

@jennifer@painless-security.com set owner to jennifer@painless-security.com

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

The edit_members view is removing all role types and only adding member roles in. Is restricting the roles it removes to member roles adequate, or does the chairs tasks menu need a way to alter the liaisons? I don't think it has one.

If it does, it could either be a separate view for the different types or separate lists on the edit_members view (or something else?)

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Didn't we solve this problem recently for the generic "edit group" form?
The way we solved the problem there should be leveraged.

Please look at #3253 and see if it is applicable.

Yes, the nomcom chair should be able to edit the liaison members as well as (voting) members.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

It's a similar bug but a different cause from #3253. There, a collision between a field named ad and a role name with slug ad caused the view to process the form incorrectly.

The code for the edit_members view is a separate path that had a filter to find any roles whose email had been removed from the list of member roles and delete them.

i.e.,

nomcom.role_set.filter(email__in=set([deleted emails])).delete()

needs to become

nomcom.role_set.filter(name__slug='member', email__in=set([deleted emails])).delete()

To add the ability to edit the liaisons and voting members lists, I could add additional menu items to the chair tasks pull-down. It would then have "Edit Members", "Edit Voting Members", "Edit Liaisons" in addition to its already rather long list. Alternatively, I could add those other lists to the current edit_members view, making it look like a partial group edit page.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Having a single view for editing all the types of members is what the chairs would expect.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Makes sense, I'll go that route then. I'll see if there's a good way to share code with the generic "edit group" form.

[ietf-svn-bot]

@jennifer@painless-security.com changed status from assigned to closed

[ietf-svn-bot]

@jennifer@painless-security.com set resolution to fixed

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Fixed in 8759955:

Allow nomcom chair to edit liaisons as well as members and generate GroupEvents when changed. Share code between group and nomcom for this purpose. Fixes #3376. Commit ready for merge.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in da9c9d8:

Merged in 8759955 from jennifer@painless-security.com:
Allow nomcom chair to edit liaisons as well as members and generate GroupEvents when changed. Share code between group and nomcom for this purpose. Fixes #3376.