owner:rcross@amsl.com resolution_fixed type_defect | by rjsparks@nostrum.com
This stanza at secr/telechat/views.py#217:
if doc.active_ballot():
ballot_type = doc.active_ballot().ballot_type
else:
ballot_type = BallotType.objects.get(doc_type='draft')
Assumes there is only one BallotType for doc_type='draft', which has not been true since we added the ability for the IRSG to ballot a draft.
The last line should probably be getting (slug='approve') instead, but the logic of the view needs to be reviewed, and a test that covers the line needs to be created.
Issue migrated from trac:3245 at 2022-03-04 08:36:35 +0000
owner:rcross@amsl.comresolution_fixedtype_defect| by rjsparks@nostrum.comThis stanza at secr/telechat/views.py#217:
Assumes there is only one BallotType for doc_type='draft', which has not been true since we added the ability for the IRSG to ballot a draft.
The last line should probably be getting (slug='approve') instead, but the logic of the view needs to be reviewed, and a test that covers the line needs to be created.
Issue migrated from trac:3245 at 2022-03-04 08:36:35 +0000