javascript test leaks outside of test framework

[ietf-svn-bot]

owner:jennifer@painless-security.com resolution_fixed type_defect | by rjsparks@nostrum.com

---

ietf.meeting.tests_js.AgendaTests.test_session_materials_modal

sends 4 OPTIONS requests outside the framework.

I spotted this when I happened to have a runserver going in a different window.

[01] "OPTIONS /meeting/72/materials/minutes-72-mars HTTP/1.1" 404 1786
[01] "OPTIONS /meeting/72/materials/agenda-72-mars HTTP/1.1" 404 1784
[01] "OPTIONS /meeting/72/materials/minutes-72-mars HTTP/1.1" 404 1786
[01] "OPTIONS /meeting/72/materials/agenda-72-mars HTTP/1.1" 404 1784

---

Issue migrated from trac:3203 at 2022-03-04 08:11:40 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to accepted

[ietf-svn-bot]

@jennifer@painless-security.com changed status from accepted to assigned

[ietf-svn-bot]

@jennifer@painless-security.com set owner to jennifer@painless-security.com

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

This is still happening with 7.36.0

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

This is the result of an xhr request in the javascript being tested. It's retrieving relative URLs passed via data-src attributes ultimately derived from the MEETING_DOC_...REF settings. Overriding those settings to be absolute paths referred to live_server_url seems to avoid this.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

This can be fixed more robustly by overriding IDTRACKER_BASE_URL with the live_server_url. That is more likely to catch future problems like this.

[ietf-svn-bot]

@jennifer@painless-security.com changed status from assigned to closed

[ietf-svn-bot]

@jennifer@painless-security.com set resolution to fixed

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Fixed in c390fe0:

Use live_server_url as IDTRACKER_BASE_URL in IetfLiveServerTestCase. Fixes #3203. Commit ready for merge.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in acd13c9:

Merged in c390fe0 from jennifer@painless-security.com:
Use live_server_url as IDTRACKER_BASE_URL in IetfLiveServerTestCase. Fixes #3203.