Milestone editing javascript needs test coverage

[ietf-svn-bot]

owner:jennifer@painless-security.com resolution_fixed type_defect | by rjsparks@nostrum.com

---

The plumbing for the javascript enabling edits at
https://datatracker.ietf.org/group/acronym/milestones/
has become disconnected.

My guess is an underlying library update cause breakage.

This needs both to be fixed, and for a set of tests that exercise the javascript to be added.

Uncaught TypeError: c is undefined
    createChoice https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:22
    addSelectedChoice https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:22
    jQuery 2
    addSelectedChoice https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:22
    updateSelection https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:22
    initSelection https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:22
    initSelection https://www.ietf.org/lib/dt/7.26.0/ietf/js/select2-field.js:55
    initSelection https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:22
    init https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:21
    select2 https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:23
    jQuery 2
    select2 https://www.ietf.org/lib/dt/7.26.0/select2/select2.min.js:23
    setupSelect2Field https://www.ietf.org/lib/dt/7.26.0/ietf/js/select2-field.js:11
    <anonymous> https://www.ietf.org/lib/dt/7.26.0/ietf/js/select2-field.js:69
    jQuery 2
    <anonymous> https://www.ietf.org/lib/dt/7.26.0/ietf/js/select2-field.js:65
    jQuery 4
select2.min.js:22:28909

---

Issue migrated from trac:3196 at 2022-03-04 08:11:11 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to accepted

[ietf-svn-bot]

@rjsparks@nostrum.com edited the issue description

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Robert tracked this to changes to select2-field.js in daf3e7b. That changed the expected format for the data-pre attribute of searchable fields that use that JavaScript library. I somehow missed that this was used for a few searchable fields other than SearchablePersonField and its subclasses.

The bug here (assuming it's the only one...) is that SearchableDocumentsField is still using the old format. The same bug affects SearchableIprDisclosuresField and SearchableLiaisonStatementsField. I believe those are the only fields that use select2-field.js, but if it's being used anywhere else, that will need to be updated, also.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fix committed as 8bf32fc (Jennifer supplied the patch).

Patched into production at 7.26.0.p2

[ietf-svn-bot]

@rjsparks@nostrum.com changed title from Milestone editing is broken to Milestone editing javascript needs test coverage

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Changing Summary to reflect what remains of this ticket.

[ietf-svn-bot]

@jennifer@painless-security.com changed status from accepted to assigned

[ietf-svn-bot]

@jennifer@painless-security.com changed owner from `` to jennifer@painless-security.com

[ietf-svn-bot]

@jennifer@painless-security.com changed status from assigned to closed

[ietf-svn-bot]

@jennifer@painless-security.com changed resolution from `` to fixed

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Fixed in 17d3772:

Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204. Commit ready for merge.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 6d7a0b6:

Merged in 17d3772 from jennifer@painless-security.com:
Consolidate repeated searchable field code into SearchableField class. Fix single-valued searchable fields. Make javascript test config reusable. Use Django Form.media for JS/CSS inclusion. Fixes #3196, #3204.