The secretariat should be able to edit the set of DocumentAuthors for a document on the main page where they are displayed

[ietf-svn-bot]

resolution_fixed type_defect | by rjsparks@nostrum.com

---

Add an edit button for the secretariat (only) at the Authors line on a drafts main page.

---

Issue migrated from trac:3185 at 2022-03-04 08:10:19 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to accepted

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

There is a class called EditedAuthorsDocEvent. Would it be appropriate to use that to log changes to the author list?

As far as I can tell this event class is not used by the current codebase. The db snapshot has around 1300 instances all created within a short time in May 2017, but I haven't been able to find how they were generated.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Look at tag 6.51.0. In particular:

https://trac.tools.ietf.org/tools/ietfdb/browser/tags/6.51.0/ietf/doc/migrations/0029_update_rfc_authors.py

And, yes, this would be a reasonable use of the class.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Ah, thank you for the pointer to the migration - I poked around but was not able to find the origin of those events.

Another question: is javascript dependency ok for the author edit page? I'm looking at the milestone editor, which allows reordering via drag-and-drop. It seems like a similar pattern would fit here.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Javascript is fine - it will be the secretariat doing work here.

But - having fewer things to break is a real pressure as well. If it simplifies the code overall, go for it. But it won't get used often enough to warrant convenience of the user at the cost of a lot of complexity to maintain.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

That depends on how we're measuring simple. The most straightforward would be to use the default Django formset behavior, which gives an integer order field that it's up to the user to manage. This is clunky, but works and would not need any scripts.

The alternative I'm contemplating is to pull the list management JS out of the milestone editor and share it. If editing/ordering lists is something that is likely to come up again, this would make it easy to reuse the mechanism. If not, then it's just extra work now.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

is it the same component that's used for reordering slides? (That one gets more use).

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

It uses the same library (Sortable.js) for ordering/dragging. It goes further and displays a list of data rows that can be clicked on to open individual edit forms and allows for review of changes before saving.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

I poked at the milestone editor a little more - I think it's going to add some needless complexity right now. The JS itself is pretty reasonable, but it requires some contortions in the HTML. So I think I'll shoot for simple.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

One more question related to workflow - is it ok to handle Person and Email records in the same way that is done for a submitted draft? There, the name and email are looked up and the necessary records are created if there's no match.

I can also hook them up as searchable fields, but that may be a little tricky because I assume it needs to allow new people/emails and not just existing ones.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

It's ok to only allow selecting already existing Person or Email objects.

If the secretary needs to, they already have other mechanisms for adding a Person or adding an Email to a Person.

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Ok, will do. Thanks.

[ietf-svn-bot]

@jennifer@painless-security.com changed status from accepted to closed

[ietf-svn-bot]

@jennifer@painless-security.com changed resolution from `` to fixed

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Fixed in 6cf9eb8:

Allow secretariat to edit document author list. Fixes #3185. Commit ready for merge.