Reviewer availability emails should include details

[ietf-svn-bot]

resolution_fixed type_enhancement | by kivinen@iki.fi

---

Now when the reviewer availability changes I as an secretary get email saying:

Subject: Reviewer availability of N.N changed in secdir

Reviewer availability of N.N in secdir changed by M.M.

https://datatracker.ietf.org/review/secdir/reviewers/

This is not really that helpful. It would be much better to know whether they marked them unavailable or marked them to available, and what are the dates for next unavailability periods.

I.e., change it to something:

Subject: Reviewer N.N changed to be unavailable in secdir

Reviewer availibility of N.N in secdir changed by M.M.

2020-02-25 -- 2020-03-30  Completely unavailable
                          On vacation
2020-06-01 -- 2020-08-30  Completely unavailable
                          On summer vacation 

or

Subject: Reviewer N.N change to be available in secdir

Reviewer availibility of N.N in secdir changed by M.M.

No unavailability periods registered.

or even:

Subject: Reviewer N.N change to be available in secdir

Reviewer availibility of N.N in secdir changed by M.M to be available now.

2020-06-01 -- 2020-08-30  Completely unavailable
                          On summer vacation 

---

Issue migrated from trac:2891 at 2022-03-04 07:41:56 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to accepted

[ietf-svn-bot]

@mark@painless-security.com commented

---

It turns out that the email template already has an interpolated variable for messages like this, but the calling code fails to supply the variable. If I update the code to supply the variable, then these messages start to appear.

This code is included in a function, email_reviewer_availability_change, that is called in several places:

• https://trac.tools.ietf.org/tools/ietfdb/browser/tags/dev/6.129.1.dev0/ietf/group/views.py#L1777
• https://trac.tools.ietf.org/tools/ietfdb/browser/tags/dev/6.129.1.dev0/ietf/group/views.py#L1822
• https://trac.tools.ietf.org/tools/ietfdb/browser/tags/dev/6.129.1.dev0/ietf/group/views.py#L1847
• https://trac.tools.ietf.org/tools/ietfdb/browser/tags/dev/6.129.1.dev0/ietf/group/views.py#L1870

Each of these have one or more messages defined. I'm going to change the message passed into the second one (line 1822) to match the formatting you have specified here, and I'll look to improve any formatting on the other invocations as well. If you have a specific request for how these messages should change, please respond on this issue.

[ietf-svn-bot]

@mark@painless-security.com commented

---

OK, I've implemented the simplest changes to address this issue. The system will now send out four bits of mail.

For adding a new (un-)availability period:

Subject: Reviewer availability of M. M. changed in iotdir
---------------------------------------------------------
Reviewer availability of Robert Sparks in iotdir changed by M. M.

2020-05-14 -- 2020-05-31 Completely unavailable
                         Testing - late May

M. M. does not have any assignments currently.

http://localhost:8000/review/iotdir/reviewers/

For other notifications, I've left the code that generates the message intact, and just forwarded the variable containing the message on to the template.

Removal:

Subject: Reviewer availability of M. M.  changed in iotdir
----------------------------------------------------------

Reviewer availability of Robert Sparks in iotdir changed by M. M.

Removed unavailable period: 2020-05-14 - 2020-05-31 (Can do follow-ups)

http://localhost:8000/review/iotdir/reviewers/

User settings change:

Subject: Reviewer availability of M. M. changed in iotdir
-----------------------------------------------------------

Reviewer availability of M. M. in iotdir changed by M. M.

Frequency changed to "Once per week" from "Not specified".

Skip next assignments changed to 15 from 0.

Reviewer has requested to be the next person selected for an assignment, as
soon as possible, and will be on the top of the queue.

http://localhost:8000/review/iotdir/reviewers/

End a previously open-ended period:

Subject: Reviewer availability of M. M. changed in iotdir
-----------------------------------------------------------------

Reviewer availability of M. M. in iotdir changed by M. M.

Set end date of unavailable period: 2020-05-14 - 2020-05-16 (Completely
unavailable)

http://localhost:8000/review/iotdir/reviewers/

[ietf-svn-bot]

@mark@painless-security.com changed status from accepted to closed

[ietf-svn-bot]

@mark@painless-security.com changed resolution from `` to fixed

[ietf-svn-bot]

@mark@painless-security.com commented

---

Fixed in 96bc71f:

Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email. Fixes #2891. Commit ready to merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 2b68095:

Merged in 96bc71f from mark@painless-security.com:
Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email. Fixes #2891.