crash when setting a reviewer to none while managing unassinged requests

[ietf-svn-bot]

resolution_fixed type_defect | by rjsparks@nostrum.com

---

The formset at /group/whatever/reviews/manage/unassigned/ lets you select a reviewer of None on a given reviewrequest row. This is to allow the group secretary to say "no, I'm not really ready to assign this right now" after clicking the control.

However, some leftover code-branches from before the ReviewAssignment refactor assume that each of the submitted forms will have a non-empty reviewer.

---

Issue migrated from trac:2812 at 2022-03-04 07:18:30 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in b158807:

Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes #2812. Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 9e21c01:

Merged in b158807 from rjsparks@nostrum.com:
Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes #2812.