resolution_fixed type_defect | by rjsparks@nostrum.com
Right now, the overview of reviews at /group//reviews shows closed reviews by looking for objects that have a completed_on date.
closed_review_assignments # closed_review_assignments.filter(completed_on__gte datetime.date.today() - date_limit)
However, when a review is rejected, the completed_on field is left as None.
Either a date needs to be set in ReviewAssignment.completed_on when a review is rejected (or withdrawn), or the above view's filter needs to be updated so that rejected and withdrawn reviews can be seen.
Setting the completed_on date is probably the better path, but the code needs to be inspected for any assumptions that having a completed_on date implies that a review was actually done.
The migrations that populated ReviewAssignments based on the earlier ReviewRequest model did populate the completed_on date for rejected assignments, so the bulk of the rejected assignments in the database do have a completed_on date. When this ticket's issues are addressed, a migration will be needed to populate the completed_on dates for those rejected assignments that don't have one.
See also #2777
Issue migrated from trac:2782 at 2022-03-04 07:15:49 +0000
resolution_fixedtype_defect| by rjsparks@nostrum.comRight now, the overview of reviews at /group//reviews shows closed reviews by looking for objects that have a completed_on date.
However, when a review is rejected, the completed_on field is left as None.
Either a date needs to be set in ReviewAssignment.completed_on when a review is rejected (or withdrawn), or the above view's filter needs to be updated so that rejected and withdrawn reviews can be seen.
Setting the completed_on date is probably the better path, but the code needs to be inspected for any assumptions that having a completed_on date implies that a review was actually done.
The migrations that populated ReviewAssignments based on the earlier ReviewRequest model did populate the completed_on date for rejected assignments, so the bulk of the rejected assignments in the database do have a completed_on date. When this ticket's issues are addressed, a migration will be needed to populate the completed_on dates for those rejected assignments that don't have one.
See also #2777
Issue migrated from trac:2782 at 2022-03-04 07:15:49 +0000