Weird default options for redirected search

[ietf-svn-bot]

resolution_fixed type_defect | by rjsparks@nostrum.com

---

When I enter a url of

https://datatracker.ietf.org/doc/record

I get redirected to

https://datatracker.ietf.org/doc/search?name=naptr&doctypes=review

Why is type "review" chosen. I would think RFCs and active internet drafts (which IIRC is the default if you search from the main page) would be the right thing to do?

---

Issue migrated from trac:2599 at 2022-03-04 06:52:55 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

This is a consequence of this conditional in views_search:

        for t in doctypenames:
            if n.startswith(t.prefix):
                search_args += "&doctypes=%s" % t.slug
                break

And some interesting in the data:

In 3e9aa2c3a07da1dc4463174af958f11aff412a72: DocTypeName.objects.filter(prefix='')
Out3e9aa2c3a07da1dc4463174af958f11aff412a72: <QuerySet [<DocTypeName: Liaison>, <DocTypeName: Review>, <DocTypeName: Shepherd's writeup>]>

Those DocTypeNames need non-empty prefixes, and the code snippet above should protect against an empty prefix.

Also note:

In 0ef541b9e097d43df3122db2b8988711b7d861d7: Document.objects.filter(type_id='shepwrit').count()
Out0ef541b9e097d43df3122db2b8988711b7d861d7: 0

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 22d4593:

Corrected some DocTypeName entries' prefix value. Made the search code more robust against DocTypeName objects that have an empty prefix value. Fixes #2599. Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 90e773a:

Merged in 22d4593 from rjsparks@nostrum.com:
Corrected some DocTypeName entries' prefix value. Made the search code more robust against DocTypeName objects that have an empty prefix value. Fixes #2599.