assignments email should note previous reviews

[ietf-svn-bot]

keyword_sprint resolution_fixed type_enhancement | by mahoney@nostrum.com

---

Currently, the assignments email places an asterisk after the name of a draft that has been reviewed previously. It would be useful to provide more information - like review type and version reviewed. For instance:

Current:

For telechat 2018-06-21

Reviewer Type LC end Draft
Joe Blow Telechat 2018-05-16 draft-ietf-blah-blah-blah-24 *

Proposed:

For telechat 2018-06-21

Reviewer Type LC end Draft
Joe Blow Telechat 2018-05-16 draft-ietf-blah-blah-blah-24 (-10 LC review, -14 Telechat review, -20 LC2 review)

---

Issue migrated from trac:2526 at 2022-03-04 06:46:09 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed keywords from review tool to sprint

[ietf-svn-bot]

@rjsparks@nostrum.com changed component from doc/ to review/

[ietf-svn-bot]

@sasha@dashcare.nl changed status from new to closed

[ietf-svn-bot]

@sasha@dashcare.nl changed resolution from `` to fixed

[ietf-svn-bot]

@sasha@dashcare.nl commented

---

Fixed in ef1e800:

Fix #2526 - List previous reviews in assignments email.

This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included /* before.

As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.

This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.

Commit ready for merge.

[ietf-svn-bot]

@sasha@dashcare.nl commented

---

This commit has a test failure (tweaked something just before committing and forgot to rerun the tests). Should have a fix committed in the next half our or so.

[ietf-svn-bot]

@sasha@dashcare.nl commented

---

Fixed in 78a1464

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 97be7f3:

Merged in ef1e800 from sasha@dashcare.nl:
Fix #2526 - List previous reviews in assignments email.
This includes a migration to update the database templates. Note that
not all templates currently included them (secdir at least), and
previous reviews are only listed in templates that included /* before.
As before, previous reviews are only included if they are done by the
same reviewer(s) as the current assignment.
This also fixes a bug in database template 182
(/group/defaults/email/open_assignments.txt) which referred to
r.review_request..doc.rev and r.review_request..requested_rev
in the template, and updates the test to use the current version of
template 182.