Admin changes (wipes out) some state relationships when editing other things

[ietf-svn-bot]

resolution_fixed type_defect | by rjsparks@nostrum.com

---

I recently added an obsoletes and updates relationship to RFC5258 using the admin document edit page.

My first attempt to save failed validation because there is a change comment field that has to be filled out. I filled that out and hit submit again, and the save was successful.

However, the draft state and the iesg state (and potentially some other states?) were reset, which is Very surprising.

Also, when I look at the admin history tab, it shows what it thought it did (which caused me to go look, because it said it changed some states), but it doesn't show me the comment it made me enter.

---

Issue migrated from trac:2524 at 2022-03-04 06:45:56 +0000

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Ugh. I realize I've run into this before, and I figured out the reason, although I don't have the details fresh in mind. The thing is, you can't (at least currently) re-use the form you get back with error(s) to re-submit — that will bork the states — you have to go back and get a fresh form, do the changes and include the comment.

[ietf-svn-bot]

@henrik@levkowetz.com changed _comment0 which not transferred by tractive

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

I think the Document page could be made safe by removing the special
StatesField and StatesWidget -- that's the part that doesn't handle
the error message roundtrip properly (all the state widget fields get
reset). The StateWidget requires an object instance, and on the error
roundtrip, there are only intermediate form values, which our custom
state widget doesn't handle (at least currently). Teaching it to
initialize properly from form data would be the alternative, I think
(without jumping in deeply enough in the code to be sure).

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 128c0a6:

Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524. Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 3b8d9ae:

Merged in 128c0a6 from rjsparks@nostrum.com:
Removed the field and widget that made editing document states easier on the document admin page since they do not survive validation failure of other fields on the form. Excluded states from the modelform since the default states widget is almost impossible to use without producing bad data. If states need to be edited through the admin, it will, for now, need to be done gruelingly through the admin form for State. Fixes #2524.