Auto-assign review rotation broken!

[ietf-svn-bot]

resolution_fixed type_defect | by mahoney@nostrum.com

---

For gen-art reviews.

I go to https://datatracker.ietf.org/group/genart/reviews/manage/unassigned/

Click the "Not Yet Assigned" button for the first draft.

The tool picks Brian Carpenter. Good so far, since Brian is "Next in review rotation". However, when I assign the next draft, the tool picks Brian again. It picks Brian for every single draft. Basically, the tool is not advancing in the list of next available reviewers.

Current "Next in the reviewer rotation" list:

Brian Carpenter
Elwyn Davies
Linda Dunbar
Francis Dupont
Roni Even ...

---

Issue migrated from trac:2443 at 2022-03-04 06:38:26 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

This is almost certainly a consequence of eb6341d.
The javascript in manage-review-requests.js is likely making assumptions about that "(None)" entry being there.

[ietf-svn-bot]

@rjsparks@nostrum.com changed _comment0 which not transferred by tractive

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 7b89db1:

Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts eb6341d. Fixes #2443. Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in a509ef0:

Merged in 7b89db1 from rjsparks@nostrum.com:
Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts eb6341d. Fixes #2443.