Premature setting of closure date of review request on uncompleted reviews.

[ietf-svn-bot]

owner:kivinen@iki.fi resolution_fixed type_defect | by elwynd@dial.pipex.com

---

I was just requested to perform a Telechat review of the DHCPv6 bis draft (https://datatracker.ietf.org/doc/draft-ietf-dhc-rfc3315bis/).

The (new) review request states that the review was closed on the day it was created:
Review request
draft-ietf-dhc-rfc3315bis
Request Review of draft-ietf-dhc-rfc3315bis
Requested rev. no specific revision (document currently at 10)
Type Telechat Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2018-01-09
Requested 2017-11-28
Other Reviews Intdir Early review of -10 by Zhen Cao
Review State Accepted
Reviewer Elwyn Davies
Assignment accepted:
Review Not completed yet
Draft last updated 2017-11-12
Review closed: 2017-11-28

This doesn't appear to interfere with my ability to accept the review request but seems somewhat odd. I just hadn't noticed this before but checking a number of other reviews in progress, it appears that the Review closed date is displayed as the review creation date until the review is submitted. It looks like this is just an aesthetic problem - it would be nice if the field displayed "(open)" or some such until the review has been completed, the request rescinded or OBEd.

---

Issue migrated from trac:2423 at 2022-03-04 06:36:28 +0000

[ietf-svn-bot]

@elwynd@dial.pipex.com edited the issue description

[ietf-svn-bot]

@henrik@levkowetz.com changed owner from `` to kivinen@iki.fi

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Hi Tero,

Could you check if this is a regression after the codesprint changes, please?

[ietf-svn-bot]

@kivinen@iki.fi commented

---

Yes, this is field was ADDED in the codesprint (there was no such field before), and I forgot to add checks to it that review was actually completed or partially completed before showing that item.

I.e., it should have something like

  {% if review_req.state_id ## "completed" or review_req.state_id "part-completed" %}

around the Review closed block in ietf/templates/doc/review/request_info.html file.

I currently do not have working development setup running, so I can't test this so I will fix this only later, when I get working test setup running again (might be next codesprint).

[ietf-svn-bot]

@henrik@levkowetz.com changed status from new to closed

[ietf-svn-bot]

@henrik@levkowetz.com changed resolution from `` to fixed

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 3f40d9c:

Applied a patch from kivinen@iki.fi to only show review completion date when the review is completed or part completed. Fixes issue #2423.