Datatracker Creation of Ballots for WG Rechartering

[ietf-svn-bot]

resolution_fixed type_defect | by avezza@amsl.com

---

When moving a wg recharter from Internal Review to External Review the datatracker is supposed to automatically create the approval ballot. This seems to have gone wrong with the recharter for SACM. When moving the charter from Internal Review to External Review it did not automatically create an approval ballot.

Is this a bug, or did something go wrong with the latest release? SACM is on the agenda for the November 30 IESG telechat, and there is no approval ballot for the ADs to fill in.

Thank you!

---

Issue migrated from trac:2421 at 2022-03-04 06:36:17 +0000

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

This document has the following ballots:

• Ready for external review (00-04) - Closed
• Approve (00-13) - Closed
• Ready for external review (01-00) - Closed
• Approve (02-00) - Open
• Ready for external review (02-00) - Open

The earlier approval ballot (for 02-00) is still open, and this is the reason why no new approval ballot was created. I've now added a warning message when you change state to external review and there's an previous open ballot; this will part of the next release.

Possibly it would be better to either refuse the state change, or automatically close the previous ballot, but I'd like to have your input before taking that step. Thoughts?

Henrik

[ietf-svn-bot]

@rjsparks@nostrum.com changed priority from n/a to major

[ietf-svn-bot]

@housley@vigilsec.com commented

---

In doc/views_charter.py, the code is:

            if charter_state.slug ## "intrev" and group.type_id "wg":
                if request.POST.get("ballot_wo_extern"):
                    create_ballot_if_not_open(charter, by, "r-wo-ext")
                else:
                    create_ballot_if_not_open(charter, by, "r-extrev")
                (e1, e2) = default_review_text(group, charter, by)
                e1.save()
                e2.save()
                e = default_action_text(group, charter, by)
                e.save()

It seems like we may need to close a previously abandoned ballot if one exists. Maybe something like:

                if doc.ballot_open(ballot_slug):
                    close_ballot(doc, by, ballot_slug)

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Russ' suggestion feels right to me.

[ietf-svn-bot]

@housley@vigilsec.com changed status from new to closed

[ietf-svn-bot]

@housley@vigilsec.com changed resolution from `` to fixed

[ietf-svn-bot]

@housley@vigilsec.com commented

---

Fixed in de6121c:

Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 4488fd8:

Merged in de6121c from housley@vigilsec.com:
Close any previous ballots when a charter goes to Internal Review or Extrernal Review. Fixes #2421.