Make the default CC for team reviews configurable per team and per review type

[ietf-svn-bot]

owner:sasha@dashcare.nl resolution_fixed type_enhancement | by rjsparks@nostrum.com

---

Right now, all the teams share a default CC configuration for completed reviews (see https://datatracker.ietf.org/mailtrigger/name/review_completed/).

This should be modified to allow teams to set different defaults from each other, and different defaults for different review types (early vs telechat for example).

---

Issue migrated from trac:2354 at 2022-03-04 05:56:28 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

See also #2328

[ietf-svn-bot]

@sasha@dashcare.nl changed owner from `` to sasha@dashcare.nl

[ietf-svn-bot]

@sasha@dashcare.nl commented

---

The SoW mentions "The code that handles the creation of a new review team should populate the appropriate mailtriggers.". Where is this code? I can't seem to find it, but maybe I'm overlooking something. I also can't find a feature for this in the web interface, other than the Django admin, but creating a new review team there seems like quite a bit of manual work for users.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Unless I've forgotten something, the relevant code is in the Secretariat part of the code, in
file .../ietf/secr/groups/views.py(75), with URL https://datatracker.ietf.org/secr/groups/add/ (but you won't have access to that in the production system).

(For Working Groups there are views under https://datatracker.ietf.org/group/chartering/, and for BoFs https://datatracker.ietf.org/wg/bofs/ , but that's not applicable here.)

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

I just looked through the relevant part of /secr and I don't think what I was thinking of is there.

I think the population of ReviewTeamSettings is done via the admin, by the secretariat, following a documented set of procedures they keep for creating groups. I'm verifying that with the secretariat now.
(And yes, it is a lot of manual work for them right now).
I think when the SoW was written we expected to have built a better experience for creating these teams.

(BTW, creating new review teams is moderately rare, and we've put up with manual fixup for the most recent ones that have been added).

I think, given the current state of things, that relying on the "build the mailtrigger if it's not there at the time of need" is the best way to go. An alternative would be to build them on ReviewTeamSettings.save, but we'd need to remember to untangle that when we did build a better review team creation experience.

So, for now, I say to disregard the sentence in question.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

see also #2790. (Sasha - that's not intended to be work under the current project).

[ietf-svn-bot]

@sasha@dashcare.nl changed status from new to closed

[ietf-svn-bot]

@sasha@dashcare.nl changed resolution from `` to fixed

[ietf-svn-bot]

@sasha@dashcare.nl commented

---

Fixed in 1390ae0:

Fix #2354 - Make review_completed configurable per team and review type

This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.

Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 25ac3b6:

Merged in 1390ae0 from sasha@dashcare.nl:
Fix #2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.