Review tool sends mail without useing mailtriggers to find the destinations

[ietf-svn-bot]

keyword_sprint resolution_fixed type_defect | by rjsparks@nostrum.com

---

See ietf.review.utils.email_review_request_change.

Much of the logic there should be moved into one or more mailtriggers.

---

Issue migrated from trac:2328 at 2022-03-04 05:54:35 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed keywords from `` to sprint

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

See also #2354

[ietf-svn-bot]

@sasha@dashcare.nl changed status from new to closed

[ietf-svn-bot]

@sasha@dashcare.nl changed resolution from `` to fixed

[ietf-svn-bot]

@sasha@dashcare.nl commented

---

Fixed in 88b7b45:

Fix #2328 - Use mailtriggers to find destinations in review app

As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.

Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 70380cb:

Merged in 88b7b45 from sasha@dashcare.nl:
Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.