Open early reviews should be considered as reviews

[ietf-svn-bot]

type_defect | by kivinen@iki.fi

---

I have document draft-ietf-i2nsf-problem-and-use-cases which has been assigned for early review for Derek Atkins. The review is not yet done, and now the document went to the last call, and the document was put for the assignment queue for new assignment. The assignment page did not show that there is already another review request for secdir in progress for that document, and did not reassign it to the same person (which would have been useless anyways, as he has not yet done previous review). It also did not close down the previous review.

I think it should most likely just suggest that I automatically close the previous early review for the document, and reassign it for the same reviewer for the last call review, or just modify the previous review request from early review to last call review.

The whole concept of having separate review types for early, last call and telechat is bit misleading, as those events just trigger when we want to do review assignments, but the time when the review comes in actually specifies whether it was early, last call, or telechat review.

I.e., if reviewer is assigned document during the early review time, and he does not do it then or during the last call time, but finishes the review for the latest draft after last call but before telechat, it should be considered as telechat review, not early review.

---

Issue migrated from trac:2222 at 2022-03-04 05:46:17 +0000

[ietf-svn-bot]

@kivinen@iki.fi commented

---

When I closed the early review request with overcome by events, so I could change the type of the review to last call, the tool does not show me that there was any kind of review request assignment done to anybody for that draft, and does not suggest the same reviewer for it than before.

It should at least show that there is or was another review request for the document, and suggest that reviewer to do rereview.

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to under_review

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

I suspect this has changed with last year's changes to the assignment tooling. We should go through this to see if the problem is still the same.

[kivinen]

Haven't seen this happening in last few years, so I assume we can simply close this issue, and if the issue is still there someone who notices it can reopen this ticket or create a new ticket.

[ajeanmahoney]

I tried recreating this issue in the sandbox: I created an Early Review request of a WG doc as a WG chair, then I assigned it to a reviewer as genart secretary. Then using a combo of WG chair, AD, and secretariat roles, I pushed the doc into LC. The document was not listed in the 'Unassigned review requests' section; it was listed in 'Open review requests', which seems to be correct behavior because the document had an assigned reviewer and the review deadline was in the future.

Then as the reviewer, I rejected the assignment. The document appeared in 'Unassigned review requests' section, which is also correct behavior. However, the 'Manage unassigned open review requests' page didn't show a history of the Early Review assignment.

[rjsparks]

However, the 'Manage unassigned open review requests' page didn't show a history of the Early Review assignment.

Is that important to change?

[ajeanmahoney]

It would be good to see who rejected it previously so the secretary wouldn't assign it to that person again; however, it's probably unlikely that the reviewer who rejected it would be next reviewer in rotation.