Removing users from review team do not remove review requests

[ietf-svn-bot]

resolution_fixed type_defect | by kivinen@iki.fi

---

I.e., I removed several members from the secdir team because of spring cleaning, but their review requests were not withdrawn. I assume we are now supposed to remove people from the team, and not put them on extended unavailable period like we did with old tool. When I removed the people there was not option for me to withdraw the reviews (like when adding unavailability period, there is option to mark reviewer completely unavailable so his reviews will be reassigned). I would have assumed that if people is removed his review request would automatically be withdrawn so secretary can reassign them.

---

Issue migrated from trac:2185 at 2022-03-04 05:43:24 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

I think this is might be chasing the wrong aspect of a different bug?

I assume the people you were removing didn't have actual live assignments you were expecting them to finish, but were rather people with outstanding overdue assignments that you would have marked as 'no response'. In the future, these no-response reviews should get automatically cleaned up, so you wouldn't have them as outstanding to deal with when removing older, inactive, reviewers.

If you are removing someone that did have an active review assignment, I think you would want a warning instead of an automatic unassign action. The circumstances around such a removal are likely to vary widely, and you will probably need to manage them manually anyhow.

[ietf-svn-bot]

@kivinen@iki.fi commented

---

No, the people who I did remove DID have live assignments. They have just dropped so many assignments, that we decided to kick them out, so we removed them from the team, and then I manually withdrawn all the reviews assigned to them. Then I reassigned the reviews for drafts, where they were still needed if there was enough time for another review, or marked them as not reviewing this version of draft, if there was no longer time.

Having warning when I remove someone who has live reviews would be good, but also just automatically withdrawing the assignments (or marking them as overcome by events or some other status), so that next time when I do assignments the documents show up again.

But this should also include early review requests, not only reviews on telechat and last call.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

This needs to be read now as what happens to ReviewAssignments when you remove a reviewer from the team. Having the system automatically mark those assignments "withdrawn" or "no-response", depending on whether the deadline has passed makes sense. If the associated ReviewRequest has not expired, and removing this reviewer leaves no other assigned reviews for the request, the request should go back into the unassigned pool (as discussed in #2186).

[ietf-svn-bot]

@sasha@dashcare.nl changed status from new to closed

[ietf-svn-bot]

@sasha@dashcare.nl changed resolution from `` to fixed

[ietf-svn-bot]

@sasha@dashcare.nl commented

---

Fixed in e145832:

Fix #2185 - Close review assignments when reviewer is removed from team.

If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.

Per fdb4c2a, if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.

Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 1674356:

Merged in e145832 from sasha@dashcare.nl:
Fix #2185 - Close review assignments when reviewer is removed from team.
If a reviewer is removed from a team, any accepted or assigned review
assignments are set to rejected if the request deadline has not passed,
or set to no-response when the request deadline has passed.
Per fdb4c2a, if this scenario happens, and there are no other active or
completed review assignments, the request is shown as an
unassigned review.