Closing review with no response does not send email

[ietf-svn-bot]

owner:henrik@levkowetz.com resolution_fixed type_enhancement | by kivinen@iki.fi

---

When I closed the review with no response status, the datatracker did not send email to the reviewer.

It should send configurable email saying that review was timed out and no review is no longer useful after this point (or something like that).

---

Issue migrated from trac:2176 at 2022-03-04 05:42:32 +0000

[ietf-svn-bot]

@henrik@levkowetz.com changed type from defect to enhancement

[ietf-svn-bot]

@kivinen@iki.fi commented

---

I do not think this is enhancement, it is bug. The old tool did send email in very few cases, but this was one of them, because we do want to send emails when secretary closes review for some reason. I.e., if secretary closes review with "No response" status that means that reviewer should be notified about this and told that his review is no longer needed as he missed the deadline.

Same thing if secretary closes the review because he withdraw the review.

If there is no email sent out, how do you assume the reviewer knows that he no longer needs to be doing the review. Wait for next weeks assignment email and notice that his name is no longer in the list? I do not think that is good solution, and sending email in those cases is essential.

Luckily the old tool do send emails, so I can still use the old tool to send those emails, but that means that I still need to keep old and new tool in sync.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

The relevant code in this case is at
https://trac.tools.ietf.org/tools/ietfdb/browser/trunk/ietf/review/utils.py#L503 - in particular the if statement at line 523.

If the review had been accepted, mail would have been sent. I suspect the thing to do here is to simply remove the if statement.

That won't result in a configurable message. That part should be considered an enhancement.

[ietf-svn-bot]

@kivinen@iki.fi commented

---

As reviewers never accept review requests, there is no point of checking whether it is accepted or not.

The old tool did have one configurable email, and it was this, i.e. the config tab had two config values:

Noresponse-subject: Your secdir review timed out: %s

Noresponse-text: This review has been timed out. The document is already been in the IESG telechat, so review of this document is no longer useful.

The %s expanded to the draft name.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

See also #2129.

[ietf-svn-bot]

@henrik@levkowetz.com changed owner from `` to henrik@levkowetz.com

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 617dac4:

Send email to reviewer when request is closed with no response. Fixes #2176. Commit ready to merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 25753da:

Merged in 617dac4 from rjsparks@nostrum.com:
Send email to reviewer when request is closed with no response. Fixes #2176.