Skip to content

can_manage_group can have better semantics #2155

@ietf-svn-bot

Description

@ietf-svn-bot

resolution_fixed type_defect | by rjsparks@nostrum.com


Right now ietf.group.utils.can_manage_group (and can_manage_group_type) have the surprising result that chairs can't manage their own group.

This leads to code that checks can_manage_group that immediately also checks to see if the user is a chair (or secretary, or lead, or whatever other role would let them, well, manage the group).

I suspect the code overall would be simpler if can_manage_group answered yes for roles like chair.

Also, can_manage_group_type and can_manage_group currently have separate (and disagreeing) implementations. One should be implemented in terms of the other.


Issue migrated from trac:2155 at 2022-03-04 05:40:48 +0000

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions