Send returns to Send screen when issuing ballot position

[ietf-svn-bot]

owner:rjsparks@nostrum.com resolution_fixed type_defect | by ted.lemon@nominum.com

---

I just sent a ballot position on draft-ietf-p2psip-self-tuning-14; when I clicked "Save and Send Email" it went to the usual double-check page, but when I clicked Send there, it went back to the same page. I think this happened to me once before, and I was fooled into double-sending the email.

---

Issue migrated from trac:1430 at 2022-03-04 03:46:34 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed owner from `` to rjsparks@nostrum.com

[ietf-svn-bot]

@ted.lemon@nominum.com commented

---

This just happened again. Here's what was in the URL bar:

http://datatracker.ietf.org/doc/draft-ietf-dime-app-design-guide/ballot/386930/emailposition/?return_to_url=http://datatracker.ietf.org/doc/draft-ietf-dime-app-design-guide/ballot/

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

The current code that keeps track of what page to return to (using the return_to_url parameter above) is too clunky. What likely happened in this case is Ted earlier used the back link (not the browser back button) on that page, edited the position text, came back to this page using [Save and Send Email] and then clicked [Send].

If you repeatedly click the send link on the ballot/.../position and ballot/.../emailposition pages, you'll end up with ridiculous URLs like <http://localhost:8000/doc/draft-ietf-savi-dhcp/ballot/389173/emailposition/?return_to_url=http://localhost:8000/doc/draft-ietf-savi-dhcp/ballot/389173/emailposition/?return_to_url=http://localhost:8000/doc/draft-ietf-savi-dhcp/ballot/>

That bit of navigation needs to be reworked completely.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

From feb57a0:

Replaces the return_to_url notion with logic that uses the session object. Related to bug #1430.

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

8305 is in the merge queue

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

From 55cef62:

Merged in feb57a0 from rjsparks@nostrum.com:\n Replaces the return_to_url notion with logic that uses the session object. Related to bug #1430.