Changing annotation tags, without changing state, produces confusing email and comment messages

[ietf-svn-bot]

keyword_sprint owner:suresh.krishnan@ericsson.com resolution_fixed type_defect | by bob.hinden@gmail.com

---

See the first two history entries for 9-17-2013 at
http://datatracker.ietf.org/doc/draft-ietf-6man-resilient-rs/history/,
particularly:

IETF WG state changed to In WG Last Call from In WG Last Call

This also resulted in an email that said:

---

The state of document draft-ietf-6man-resilient-rs has been updated. See more information below.

Previous state: In WG Last Call
Current state: In WG Last Call
Transition date: 2013-09-17 12:57
Author of the change: Robert Hinden

Comment:

---

The messages need to be clearer when only the annotation tags have changed.

---

Issue migrated from trac:1127 at 2022-03-04 02:57:31 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed keywords from `` to sprint

[ietf-svn-bot]

@rjsparks@nostrum.com changed owner from esanchez@yaco.es to ``

[ietf-svn-bot]

@rjsparks@nostrum.com changed priority from medium to major

[ietf-svn-bot]

@suresh.krishnan@ericsson.com changed status from new to assigned

[ietf-svn-bot]

@suresh.krishnan@ericsson.com changed owner from `` to suresh.krishnan@ericsson.com

[ietf-svn-bot]

@suresh.krishnan@ericsson.com commented

---

After closer investigation, I found out that two emails were getting sent. One with the correct annotation tag changes and another one with the bad confusing information that Bob mentioned in this. Overall, the issue is a bit more widespread than just this bug. The state change emails were getting sent whenever anything changed in the IETF state of the document (including comments and annotation tags). I have changed the behavior to do the following

case: Only annotation tags changed -> Send annotation tags changed email (no state change mails)

case: Only comment changed -> No emails. Just add a history entry.

case: State changed -> Send state change emails. Include comments in the email if any were entered. If annotation tags were also changed, send a separate annotation tag change email.

[ietf-svn-bot]

@suresh.krishnan@ericsson.com changed _comment0 which not transferred by tractive

[ietf-svn-bot]

@suresh.krishnan@ericsson.com changed status from assigned to closed

[ietf-svn-bot]

@suresh.krishnan@ericsson.com changed resolution from `` to fixed

[ietf-svn-bot]

@suresh.krishnan@ericsson.com commented

---

For case 3 optimized the code further to send out only one email by folding in the annotation tag changes into the state change mail.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 8ec6c33:

Merged 74c7230 and 629816a from suresh.krishnan@ericsson.com:

Refactored the mails sent when state is changed along with annotation tags.
Don't send emails for only comment changes, just add a history entry. For
state changes and annotation changes, only send one email, containing
information about both state changes and annotation tag changes.
Fixes issue #1127.