Skip to content

Commit eb28ac8

Browse files
committed
Removed the ValueError exceptions introduced in the previous revision of the draft author extraction code. Fixes issue ietf-tools#858.
- Legacy-Id: 4753
1 parent 6be46a9 commit eb28ac8

1 file changed

Lines changed: 19 additions & 22 deletions

File tree

ietf/utils/draft.py

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import sys
4141
import time
4242

43-
version = "0.26"
43+
version = "0.27"
4444
program = os.path.basename(sys.argv[0])
4545
progdir = os.path.dirname(sys.argv[0])
4646

@@ -142,24 +142,8 @@ def __init__(self, text, source):
142142
for pagestart in range(0, len(self.lines), 58):
143143
self.pages += [ "\n".join(self.lines[pagestart:pagestart+54]) ]
144144

145-
try:
146-
self.filename, self.revision = self._parse_draftname()
147-
except ValueError, e:
148-
_warn("While processing '%s': %s" % (self.source, e))
149-
try:
150-
path, base = self.source.rsplit("/", 1)
151-
except ValueError:
152-
path, base = "", self.source
153-
if base.startswith("draft-"):
154-
name, ext = base.split(".", 1)
155-
revmatch = re.search("\d\d$", name)
156-
if revmatch:
157-
self.filename = name[:-3]
158-
self.revision = name[-2:]
159-
else:
160-
raise ValueError(e+"\n"+self.source)
161-
else:
162-
raise ValueError(e+"\n"+self.source)
145+
146+
self.filename, self.revision = self._parse_draftname()
163147

164148
self._authors = None
165149
self._authors_with_firm = None
@@ -179,11 +163,24 @@ def _parse_draftname(self):
179163
if draftname_match:
180164
return (draftname_match.group(1), draftname_match.group(2) )
181165
elif rfcnum_match:
182-
return ("rfc"+rfcnum_match.group(2), None )
166+
return ("rfc"+rfcnum_match.group(2), "")
183167
else:
184168
self.errors["draftname"] = "Could not find the draft name and revision on the first page."
185-
raise ValueError, self.errors["draftname"] + "\n'"+self.text.strip()[:240] + "'..."
186-
return ("", "")
169+
filename = ""
170+
revision = ""
171+
try:
172+
path, base = self.source.rsplit("/", 1)
173+
except ValueError:
174+
path, base = "", self.source
175+
if base.startswith("draft-"):
176+
name, ext = base.split(".", 1)
177+
revmatch = re.search("\d\d$", name)
178+
if revmatch:
179+
filename = name[:-3]
180+
revision = name[-2:]
181+
else:
182+
filename = name
183+
return filename, revision
187184

188185
# ----------------------------------------------------------------------
189186
def _stripheaders(self):

0 commit comments

Comments
 (0)