Skip to content

Commit da3e916

Browse files
committed
Moves the prefix for the URI to use for rfcdiff into settings.py.
Fixes bug ietf-tools#808 - Legacy-Id: 4701
1 parent 8ff61de commit da3e916

11 files changed

Lines changed: 18 additions & 12 deletions

ietf/context_processors.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55

66
def server_mode(request):
77
return {'server_mode': settings.SERVER_MODE}
8+
9+
def rfcdiff_prefix(request):
10+
return {'rfcdiff_prefix': settings.RFCDIFF_PREFIX}
811

912
def revision_info(request):
1013
return {'revision_time': __date__[7:32], 'revision_date': __date__[7:17], 'revision_num': __rev__[6:-2], "revision_id": __id__[5:-2], "version_num": __version__ }

ietf/idrfc/views_doc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ def _get_history(doc, versions):
468468
filename = u"%s-%s" % (e.doc.name, e.newrevisiondocevent.rev)
469469
e.desc = 'New version available: <a href="http://tools.ietf.org/id/%s.txt">%s</a>' % (filename, filename)
470470
if int(e.newrevisiondocevent.rev) != 0:
471-
e.desc += ' (<a href="http://tools.ietf.org/rfcdiff?url2=%s">diff from -%02d</a>)' % (filename, int(e.newrevisiondocevent.rev) - 1)
471+
e.desc += ' (<a href="http:{{rfcdiff_prefix}}?url2=%s">diff from -%02d</a>)' % (filename, int(e.newrevisiondocevent.rev) - 1)
472472
info["dontmolest"] = True
473473

474474
multiset_ballot_text = "This was part of a ballot set with: "

ietf/settings.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@
121121
'django.core.context_processors.i18n',
122122
'django.core.context_processors.request',
123123
'ietf.context_processors.server_mode',
124-
'ietf.context_processors.revision_info'
124+
'ietf.context_processors.revision_info',
125+
'ietf.context_processors.rfcdiff_prefix',
125126
)
126127

127128
INSTALLED_APPS = (
@@ -173,6 +174,7 @@
173174

174175
# no slash at end
175176
IDTRACKER_BASE_URL = "http://datatracker.ietf.org"
177+
RFCDIFF_PREFIX = "//www.ietf.org/rfcdiff"
176178

177179
# Valid values:
178180
# 'production', 'test', 'development'

ietf/submit/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,8 @@ def announce_to_lists(request, submission):
215215
if submission.group_acronym:
216216
m.cc = submission.group_acronym.email_address
217217
m.body = render_to_string('submit/announce_to_lists.txt', dict(submission=submission,
218-
authors=authors))
218+
authors=authors,
219+
settings=settings,))
219220
m.save()
220221
m.related_docs.add(Document.objects.get(name=submission.filename))
221222

ietf/templates/idrfc/date_column.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@
3232
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3333
{% endcomment %}
3434
{% load ietf_filters %}<td class="date">{% if not doc.rfc %}{{ doc.publication_date }}{% else %}{{ doc.publication_date|date:"Y-m" }}{% endif %}
35-
{% if doc.publication_date|timesince_days|new_enough:request %}<br/><span class="ietf-small ietf-highlight-y">{% if not doc.rfc%}<a href="http://tools.ietf.org/rfcdiff?url2={{doc.id.draft_name_and_revision}}">new</a>{%else%}new{%endif%}</span>{%endif%}
35+
{% if doc.publication_date|timesince_days|new_enough:request %}<br/><span class="ietf-small ietf-highlight-y">{% if not doc.rfc%}<a href="http:{{rfcdiff_prefix}}?url2={{doc.id.draft_name_and_revision}}">new</a>{%else%}new{%endif%}</span>{%endif%}
3636
{% if doc.id and doc.id.expected_expiration_date and doc.id.expected_expiration_date|timesince_days|expires_soon:request %}<br/><span class="ietf-small ietf-highlight-y">expires soon</span>{%endif%}
3737
</td>

ietf/templates/idrfc/doc_diffs.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
<div class="ietf-box diffTool">
3636
<h2 style="margin-top:0;margin-bottom:4px;">Diffs</h2>
37-
<form action="http{% if request.is_secure %}s{% endif %}://tools.ietf.org/rfcdiff" method="get" target="_blank" style="margin:0;">
37+
<form action="http{% if request.is_secure %}s{% endif %}:{{rfcdiff_prefix}}" method="get" target="_blank" style="margin:0;">
3838
<table>
3939
<tr><td>
4040
<label>From:</label> <select name="url1">

ietf/templates/idrfc/doc_history.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
{% if c.is_rev %}
4444
<td>{{ c.revision }}</td>
4545
<td>(System)</td>
46-
<td>New version available: <a href="http://tools.ietf.org/id/{{c.draft_name}}-{{c.revision}}.txt">{{c.draft_name}}-{{c.revision}}</a> {% ifnotequal c.revision "00" %}(<a href="http://tools.ietf.org/rfcdiff?url2={{c.draft_name}}-{{c.revision}}">diff from -{{c.revision|add:"-1"|stringformat:"02d"}}</a>){% endifnotequal %}</td>
46+
<td>New version available: <a href="http://tools.ietf.org/id/{{c.draft_name}}-{{c.revision}}.txt">{{c.draft_name}}-{{c.revision}}</a> {% ifnotequal c.revision "00" %}(<a href="http:{{rfcdiff_prefix}}?url2={{c.draft_name}}-{{c.revision}}">diff from -{{c.revision|add:"-1"|stringformat:"02d"}}</a>){% endifnotequal %}</td>
4747
{% endif %}
4848

4949
{% if c.is_text %}

ietf/templates/idrfc/document_history.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<div class="ietf-box diffTool">
1616
<h2>Diffs</h2>
1717

18-
<form action="http{% if request.is_secure %}s{% endif %}://tools.ietf.org/rfcdiff" method="get" target="_blank">
18+
<form action="http{% if request.is_secure %}s{% endif %}:{{rfcdiff_prefix}}" method="get" target="_blank">
1919
<table>
2020
<tr>
2121
<td>

ietf/templates/submit/announce_new_version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The IETF datatracker page for this Internet-Draft is:
99
https://datatracker.ietf.org/doc/{{ submission.filename }}/
1010

1111
Diff from previous version:
12-
http://tools.ietf.org/rfcdiff?url2={{ submission.filename }}-{{ submission.revision }}
12+
http:{{rfcdiff_prefix}}?url2={{ submission.filename }}-{{ submission.revision }}
1313

1414
IETF Secretariat.
1515
{% endautoescape %}

ietf/templates/submit/announce_to_authors.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ Number of pages: {{ submission.txt_page_count }}
1212
URL: http://www.ietf.org/internet-drafts/{{ submission.filename }}-{{ submission.revision }}.txt
1313
Status: http://datatracker.ietf.org/doc/{{ submission.filename }}
1414
Htmlized: http://tools.ietf.org/html/{{ submission.filename }}-{{ submission.revision }}
15-
{% ifnotequal submission.revision "00" %}Diff: http://tools.ietf.org/rfcdiff?url2={{ submission.filename }}-{{ submission.revision }}{% endifnotequal %}
15+
{% ifnotequal submission.revision "00" %}Diff: http:{{rfcdiff_prefix}}?url2={{ submission.filename }}-{{ submission.revision }}{% endifnotequal %}
1616

1717
Abstract:
1818
{{ submission.abstract }}
1919

2020
{{ submission.comment_to_sec|default:"" }}
2121

2222
The IETF Secretariat
23-
{% endautoescape %}
23+
{% endautoescape %}

0 commit comments

Comments
 (0)