Skip to content

Commit d22da62

Browse files
committed
Only gather addresses instead of name_addrs for the group_secretaries Mailtrigger Recipient. Fixes ietf-tools#2847. Commit ready for merge.
- Legacy-Id: 17148
1 parent 18b8a79 commit d22da62

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

ietf/doc/tests_review.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def test_close_request(self):
229229
self.assertEqual(len(outbox), 1)
230230
self.assertIn('<reviewer@example.com>', outbox[0]["To"])
231231
self.assertNotIn("<reviewsecretary@example.com>", outbox[0]["To"])
232-
self.assertIn("<reviewsecretary2@example.com>", outbox[0]["CC"])
232+
self.assertIn("reviewsecretary2@example.com", outbox[0]["CC"])
233233
mail_content = outbox[0].get_payload(decode=True).decode("utf-8").lower()
234234
self.assertIn("closed", mail_content)
235235
self.assertIn("review_request_close_comment", mail_content)
@@ -1055,7 +1055,7 @@ def test_edit_deadline(self):
10551055
review_req = reload_db_objects(review_req)
10561056
self.assertEqual(review_req.deadline,new_deadline)
10571057
self.assertEqual(len(outbox), 1)
1058-
self.assertIn('<reviewsecretary@example.com>', outbox[0]["Cc"])
1058+
self.assertIn('reviewsecretary@example.com', outbox[0]["Cc"])
10591059
self.assertIn('<reviewer@example.com>', outbox[0]["To"])
10601060
self.assertIn('Deadline changed', outbox[0]['Subject'])
10611061

ietf/mailtrigger/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def gather_group_secretaries(self, **kwargs):
183183
addrs = get_email_addresses_from_text(rts.secr_mail_alias)
184184
else:
185185
for role in group.role_set.filter(name='secr'):
186-
addrs.append(role.person.formatted_email())
186+
addrs.append(role.email.address)
187187
return addrs
188188

189189
def gather_review_req_reviewers(self, **kwargs):

0 commit comments

Comments
 (0)