Skip to content

Commit b9d5352

Browse files
committed
Display the reviewed revision in reviewer overview page
- Legacy-Id: 12245
1 parent 70dfb76 commit b9d5352

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

ietf/group/views_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def reviewer_overview(request, acronym, group_type=None):
137137
for d in req_data:
138138
# any open requests pushes the others out
139139
if ((d.state in ("requested", "accepted") and len(latest_reqs) < MAX_REQS) or (len(latest_reqs) + open_reqs < MAX_REQS)):
140-
latest_reqs.append((d.req_pk, d.doc, d.deadline,
140+
latest_reqs.append((d.req_pk, d.doc, d.reviewed_rev, d.deadline,
141141
review_state_by_slug.get(d.state),
142142
int(math.ceil(d.assignment_to_closure_days)) if d.assignment_to_closure_days is not None else None))
143143
person.latest_reqs = latest_reqs

ietf/review/utils.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def days_needed_to_fulfill_min_interval_for_reviewers(team):
151151
return res
152152

153153
ReviewRequestData = namedtuple("ReviewRequestData", [
154-
"req_pk", "doc", "doc_pages", "req_time", "state", "deadline", "result", "team", "reviewer",
154+
"req_pk", "doc", "doc_pages", "req_time", "state", "deadline", "reviewed_rev", "result", "team", "reviewer",
155155
"late_days",
156156
"request_to_assignment_days", "assignment_to_closure_days", "request_to_closure_days"])
157157

@@ -179,7 +179,7 @@ def extract_review_request_data(teams=None, reviewers=None, time_from=None, time
179179

180180
# left outer join with RequestRequestDocEvent for request/assign/close time
181181
event_qs = event_qs.values_list(
182-
"pk", "doc", "doc__pages", "time", "state", "deadline", "result", "team",
182+
"pk", "doc", "doc__pages", "time", "state", "deadline", "reviewed_rev", "result", "team",
183183
"reviewer__person", "reviewrequestdocevent__time", "reviewrequestdocevent__type"
184184
)
185185

@@ -200,7 +200,7 @@ def positive_days(time_from, time_to):
200200
requested_time = assigned_time = closed_time = None
201201

202202
for e in events:
203-
req_pk, doc, doc_pages, req_time, state, deadline, result, team, reviewer, event_time, event_type = e
203+
req_pk, doc, doc_pages, req_time, state, deadline, reviewed_rev, result, team, reviewer, event_time, event_type = e
204204

205205
if event_type == "requested_review" and requested_time is None:
206206
requested_time = event_time
@@ -214,7 +214,7 @@ def positive_days(time_from, time_to):
214214
assignment_to_closure_days = positive_days(assigned_time, closed_time)
215215
request_to_closure_days = positive_days(requested_time, closed_time)
216216

217-
d = ReviewRequestData(req_pk, doc, doc_pages, req_time, state, deadline, result, team, reviewer,
217+
d = ReviewRequestData(req_pk, doc, doc_pages, req_time, state, deadline, reviewed_rev, result, team, reviewer,
218218
late_days, request_to_assignment_days, assignment_to_closure_days,
219219
request_to_closure_days)
220220

@@ -230,7 +230,7 @@ def aggregate_raw_review_request_stats(review_request_data, count=None):
230230
assignment_to_closure_days_list = []
231231
assignment_to_closure_days_count = 0
232232

233-
for (req_pk, doc, doc_pages, req_time, state, deadline, result, team, reviewer,
233+
for (req_pk, doc, doc_pages, req_time, state, deadline, reviewed_rev, result, team, reviewer,
234234
late_days, request_to_assignment_days, assignment_to_closure_days, request_to_closure_days) in review_request_data:
235235
if count == "pages":
236236
c = doc_pages

ietf/templates/group/reviewer_overview.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ <h2>Reviewers</h2>
3333
<td>{% if person.settings_url %}<a href="{{ person.settings_url }}">{% endif %}{{ person }}{% if person.settings_url %}</a>{% endif %}</td>
3434
<td>
3535
<table class="simple-table">
36-
{% for req_pk, doc_name, deadline, state, assignment_to_closure_days in person.latest_reqs %}
36+
{% for req_pk, doc_name, reviewed_rev, deadline, state, assignment_to_closure_days in person.latest_reqs %}
3737
<tr>
3838
<td><a href="{% url "ietf.doc.views_review.review_request" name=doc_name request_id=req_pk %}">{{ deadline|date }}</a></td>
3939
<td>
@@ -42,7 +42,7 @@ <h2>Reviewers</h2>
4242
<td>
4343
{% if assignment_to_closure_days != None %}{{ assignment_to_closure_days }}&nbsp;day{{ assignment_to_closure_days|pluralize }}{% endif %}
4444
</td>
45-
<td>{{ doc_name }}</td>
45+
<td>{{ doc_name }}{% if reviewed_rev %}-{{ reviewed_rev }}{% endif %}</td>
4646
</div>
4747
{% endfor %}
4848
</table>

0 commit comments

Comments
 (0)