Skip to content

Commit 70dfb76

Browse files
committed
Don't import reviewer roles for completely unavailable reviewers who were marked as away until after 2020
- Legacy-Id: 12244
1 parent 77d7d8b commit 70dfb76

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

ietf/review/import_from_review_tool.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ def parse_timestamp(t):
113113
print "created role", unicode(role).encode("utf-8")
114114

115115
if row.login in known_reviewers:
116-
if row.comment != "Inactive" and row.available != 2145916800: # corresponds to 2038-01-01
116+
if (row.comment != "Inactive"
117+
and row.available != 2145916800 # corresponds to 2038-01-01
118+
and (not parse_timestamp(row.available) or parse_timestamp(row.available).date() < datetime.date(2020, 1, 1))):
119+
117120
role, created = Role.objects.get_or_create(name=RoleName.objects.get(slug="reviewer"), person=email.person, email=email, group=team)
118121

119122
if created:

0 commit comments

Comments
 (0)