Skip to content

Commit b768dbb

Browse files
committed
Added a preference to not display the left-hand menubar. Addresses issues ietf-tools#1659 and ietf-tools#1663.
- Legacy-Id: 9643
1 parent 2fa307a commit b768dbb

4 files changed

Lines changed: 38 additions & 7 deletions

File tree

ietf/cookies/urls.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,6 @@
1111
(r'^expires_soon/', views.expires_soon),
1212
(r'^full_draft/(?P<enabled>.*)$', views.full_draft),
1313
(r'^full_draft/', views.full_draft),
14+
(r'^left_menu/(?P<enabled>.*)$', views.left_menu),
15+
(r'^left_menu/', views.left_menu),
1416
)

ietf/cookies/views.py

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from django.shortcuts import render_to_response as render
44
from django.template import RequestContext
55

6-
def settings(request, new_enough = -1, expires_soon = -1, full_draft = ""):
6+
def settings(request, new_enough = -1, expires_soon = -1, full_draft = "", left_menu=""):
77
if new_enough < 0:
88
if "new_enough" in request.COOKIES and request.COOKIES["new_enough"].isdigit():
99
new_enough = int(request.COOKIES["new_enough"])
@@ -21,11 +21,19 @@ def settings(request, new_enough = -1, expires_soon = -1, full_draft = ""):
2121
full_draft = "off"
2222
else:
2323
full_draft = "off"
24+
if left_menu == "":
25+
if "left_menu" in request.COOKIES:
26+
left_menu = request.COOKIES["left_menu"]
27+
if left_menu != 'on' and left_menu != 'off':
28+
left_menu = "on"
29+
else:
30+
left_menu = "on"
2431
return render("cookies/settings.html",
2532
{
2633
"new_enough" : new_enough,
2734
"expires_soon" : expires_soon,
28-
"full_draft" : full_draft
35+
"full_draft" : full_draft,
36+
"left_menu": left_menu,
2937
}, context_instance=RequestContext(request))
3038

3139
def new_enough(request, days="14"):
@@ -35,7 +43,7 @@ def new_enough(request, days="14"):
3543
days = 0
3644
if days == 0:
3745
days = 14
38-
response = settings(request, days, -1)
46+
response = settings(request, new_enough=days)
3947
response.set_cookie("new_enough", days, 315360000)
4048
return response
4149

@@ -46,13 +54,24 @@ def expires_soon(request, days="14"):
4654
days = 0
4755
if days == 0:
4856
days = 14
49-
response = settings(request, -1, days)
57+
response = settings(request, expires_soon=days)
5058
response.set_cookie("expires_soon", days, 315360000)
5159
return response
5260

5361
def full_draft(request, enabled="off"):
5462
if enabled != "on" and enabled != "off":
5563
enabled = "off"
56-
response = settings(request, -1, -1, enabled)
64+
response = settings(request, full_draft=enabled)
5765
response.set_cookie("full_draft", enabled, 315360000)
5866
return response
67+
68+
def left_menu(request, enabled="on"):
69+
if enabled != "on" and enabled != "off":
70+
enabled = "on"
71+
# Propagate the new setting immediately, to render the settings page
72+
# iteself according to the setting:
73+
request.COOKIES["left_menu"] = enabled
74+
response = settings(request, left_menu=enabled)
75+
response.set_cookie("left_menu", enabled, 315360000)
76+
return response
77+

ietf/templates/base.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@
9292
</div>
9393
</div>
9494
{% endif %}
95-
96-
{% if not hide_menu %} {# ugly hack for the more or less unported meeting agenda edit pages #}
95+
{% if request.COOKIES.left_menu != "off" and not hide_menu %} {# ugly hack for the more or less unported meeting agenda edit pages #}
9796
<div class="row">
9897
<div class="col-md-2 visible-md visible-lg leftmenu">
9998
<ul class="nav nav-pills nav-stacked panel panel-default panel-body">

ietf/templates/cookies/settings.html

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,16 @@ <h2 class="ietf-divider">Show full document text by default?</h2>
5050
<a class="btn btn-default {% if full_draft == "on" %}active{% endif %}" href="/accounts/settings/full_draft/on">On</a>
5151
</div>
5252

53+
<h2 class="ietf-divider">Show the left-hand menu?</h2>
54+
55+
<p>Show the left-hand menu on all regular pages? This defaults to on.</p>
56+
57+
<div class="btn-group btn-group-justified">
58+
<a class="btn btn-default {% if left_menu == "off" %}active{% endif %}" href="/accounts/settings/left_menu/off">Off</a>
59+
<a class="btn btn-default {% if left_menu == "on" %}active{% endif %}" href="/accounts/settings/left_menu/on">On</a>
60+
</div>
61+
62+
63+
5364
{% endblock %}
5465

0 commit comments

Comments
 (0)