Remove some pre-ReviewAssignment refactor logic, and simplify what remains while still allowing a group secretary to not assign a row on the unassigned requests form after touching the control to assign a reviewer. Fixes ietf-tools#2812. Commit ready for merge.

 - Legacy-Id: 16854

Author: rjsparks

ietf/doc/views_review.py

@@ -281,7 +281,7 @@ def close_request(request, name, request_id):
 
 
 class AssignReviewerForm(forms.Form):
-    reviewer = PersonEmailChoiceField(label="Assign Additional Reviewer", empty_label="(None)", required=False)
+    reviewer = PersonEmailChoiceField(label="Assign Additional Reviewer", empty_label="(None)")
     add_skip = forms.BooleanField(label='Skip next time', required=False)
 
     def __init__(self, review_req, *args, **kwargs):

ietf/group/views.py

@@ -1509,16 +1509,15 @@ def manage_review_requests(request, acronym, group_type=None, assignment_status=
                 if action=="close":
                     close_review_request(request, review_req, review_req.form.cleaned_data["close"],
                                          review_req.form.cleaned_data["close_comment"])
-                elif action=="assign":
+                elif action=="assign" and review_req.form.cleaned_data["reviewer"]:
                     reqs_to_assign.append(review_req)
 
             assignments_by_person = dict()
             for r in reqs_to_assign:
-                if r.form.cleaned_data["reviewer"]:
-                    person = r.form.cleaned_data["reviewer"].person
-                    if not person in assignments_by_person:
-                        assignments_by_person[person] = []
-                    assignments_by_person[person].append(r)
+                person = r.form.cleaned_data["reviewer"].person
+                if not person in assignments_by_person:
+                    assignments_by_person[person] = []
+                assignments_by_person[person].append(r)
 
             # Make sure the any assignments to the person at the head
             # of the rotation queue are processed first so that the queue

ietf/review/utils.py

@@ -30,6 +30,8 @@
                                 ReviewSecretarySettings)
 from ietf.utils.mail import send_mail
 from ietf.doc.utils import extract_complete_replaces_ancestor_mapping_for_docs
+from ietf.utils import log
+
 
 def active_review_teams():
     return Group.objects.filter(reviewteamsettings__isnull=False,state="active")
@@ -402,6 +404,10 @@ def email_reviewer_availability_change(request, team, reviewer_role, msg, by):
 
 def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=False):
     assert review_req.state_id in ("requested", "assigned")
+    # In the original implementation, review unassignments could be made on formsets by setting reviewers to None.
+    # After refactoring to explicitly model ReviewAssignments, this no longer makes sense. Unassignment is now done
+    # with a differnet view on a ReviewAssignment.
+    log.assertion('reviewer is not None')
 
     if review_req.reviewassignment_set.filter(reviewer=reviewer).exists():
         return
@@ -414,8 +420,7 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa
 
     assignment = review_req.reviewassignment_set.create(state_id='assigned', reviewer = reviewer, assigned_on = datetime.datetime.now())
 
-    if reviewer:
-        possibly_advance_next_reviewer_for_team(review_req.team, reviewer.person_id, add_skip)
+    possibly_advance_next_reviewer_for_team(review_req.team, reviewer.person_id, add_skip)
 
     ReviewRequestDocEvent.objects.create(
         type="assigned_review_request",
@@ -425,7 +430,7 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa
         desc="Request for {} review by {} is assigned to {}".format(
             review_req.type.name,
             review_req.team.acronym.upper(),
-            reviewer.person if reviewer else "(None)",
+            reviewer.person,
         ),
         review_request=review_req,
         state_id='assigned',
@@ -439,7 +444,7 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa
         desc="Request for {} review by {} is assigned to {}".format(
             review_req.type.name,
             review_req.team.acronym.upper(),
-            reviewer.person if reviewer else "(None)",
+            reviewer.person,
         ),
         review_assignment=assignment,
         state_id='assigned',