Disallow saving unchanged template text. Remove stub for relations. Test changes to notify.

 - Legacy-Id: 19203

Author: rjsparks

ietf/doc/tests_bofreq.py

@@ -10,6 +10,7 @@
 
 from django.conf import settings
 from django.urls import reverse as urlreverse
+from django.template.loader import render_to_string
 
 from ietf.group.factories import RoleFactory
 from ietf.doc.factories import BofreqFactory, NewRevisionDocEventFactory
@@ -326,6 +327,10 @@ def test_start_new_bofreq(self):
         login_testing_unauthorized(self,nobody.user.username,url)
         r = self.client.get(url)
         self.assertContains(r,'Fill in the details below. Keep items in the order they appear here.',status_code=200)
+        r = self.client.post(url, dict(title='default', 
+                                       bofreq_submission='enter',
+                                       bofreq_content=render_to_string('doc/bofreq/bofreq_template.md',{})))
+        self.assertContains(r, 'The example content may not be saved.', status_code=200)
         file = NamedTemporaryFile(delete=False,mode="w+",encoding='utf-8')
         file.write('some stuff')
         file.close()
@@ -360,3 +365,21 @@ def test_start_new_bofreq(self):
             self.assertEqual(r.status_code, 200)
             q = PyQuery(r.content)
             self.assertTrue(q('form div.has-error'))
+
+    def test_change_notify(self):
+        doc = BofreqFactory()
+        url = urlreverse('ietf.doc.views_doc.edit_notify;bofreq', kwargs=dict(name=doc.name))
+        login_testing_unauthorized(self, "secretary", url)
+
+        # get
+        r = self.client.get(url)
+        self.assertEqual(r.status_code,200)
+        q = PyQuery(r.content)
+        self.assertEqual(len(q('form input[name=notify]')),1)
+
+        # Provide a list
+        r = self.client.post(url,dict(notify="TJ2APh2P@ietf.org",save_addresses="1"))
+        self.assertEqual(r.status_code,302)
+        doc = reload_db_objects(doc)
+        self.assertEqual(doc.notify,'TJ2APh2P@ietf.org')
+        

ietf/doc/urls_bofreq.py

@@ -4,7 +4,6 @@
 
 urlpatterns = [
     url(r'^notices/$',               views_doc.edit_notify,              name='ietf.doc.views_doc.edit_notify;bofreq'),
-    url(r'^relations/$',             views_bofreq.edit_relations),
     url(r'^state/$',                 views_bofreq.change_state),
     url(r'^submit/$',                views_bofreq.submit),
     url(r'^title/$',                 views_bofreq.edit_title),

ietf/doc/views_bofreq.py

@@ -32,10 +32,6 @@ def bof_requests(request):
     return render(request, 'doc/bofreq/bof_requests.html',dict(reqs=reqs))
 
 
-def edit_relations(request, name):
-    raise NotImplementedError
-
-
 class BofreqUploadForm(forms.Form):
     ACTIONS = [
         ("enter", "Enter content directly"),
@@ -47,6 +43,9 @@ class BofreqUploadForm(forms.Form):
 
     def clean_bofreq_content(self):
         content = self.cleaned_data["bofreq_content"].replace("\r", "")
+        default_content = render_to_string('doc/bofreq/bofreq_template.md',{})
+        if content==default_content:
+            raise forms.ValidationError('The example content may not be saved. Edit it as instructed to document this BoF request.')
         try:
             _ = markdown.markdown(content, extensions=['extra'])
         except Exception as e: