Added the notion of responsible leadership.

 - Legacy-Id: 19202

Author: rjsparks

ietf/doc/admin.py

@@ -12,7 +12,7 @@
     TelechatDocEvent, BallotPositionDocEvent, ReviewRequestDocEvent, InitialReviewDocEvent,
     AddedMessageEvent, SubmissionDocEvent, DeletedEvent, EditedAuthorsDocEvent, DocumentURL,
     ReviewAssignmentDocEvent, IanaExpertDocEvent, IRSGBallotDocEvent, DocExtResource, DocumentActionHolder,
-    BofreqEditorDocEvent )
+    BofreqEditorDocEvent, BofreqResponsibleDocEvent )
 
 from ietf.utils.validators import validate_external_resource_value
 
@@ -198,6 +198,10 @@ class BofreqEditorDocEventAdmin(DocEventAdmin):
     raw_id_fields = ["doc", "by", "editors" ]
 admin.site.register(BofreqEditorDocEvent, BofreqEditorDocEventAdmin)
 
+class BofreqResponsibleDocEventAdmin(DocEventAdmin):
+    raw_id_fields = ["doc", "by", "responsible" ]
+admin.site.register(BofreqResponsibleDocEvent, BofreqResponsibleDocEventAdmin)
+    
 class DocumentUrlAdmin(admin.ModelAdmin):
     list_display = ['id', 'doc', 'tag', 'url', 'desc', ]
     search_fields = ['doc__name', 'url', ]

ietf/doc/factories.py

@@ -13,9 +13,10 @@
 
 from ietf.doc.models import ( Document, DocEvent, NewRevisionDocEvent, DocAlias, State, DocumentAuthor,
     StateDocEvent, BallotPositionDocEvent, BallotDocEvent, BallotType, IRSGBallotDocEvent, TelechatDocEvent,
-    DocumentActionHolder, BofreqEditorDocEvent )
+    DocumentActionHolder, BofreqEditorDocEvent, BofreqResponsibleDocEvent )
 from ietf.group.models import Group
 from ietf.person.factories import PersonFactory
+from ietf.group.factories import RoleFactory
 from ietf.utils.text import xslugify
 
 
@@ -401,12 +402,32 @@ def editors(obj, create, extracted, **kwargs):
             obj.editors.set(PersonFactory.create_batch(3))
         obj.desc = f'Changed editors to {", ".join(obj.editors.values_list("name",flat=True)) or "(None)"}'
 
+class BofreqResponsibleDocEventFactory(DocEventFactory):
+    class Meta:
+        model = BofreqResponsibleDocEvent
+
+    type = "changed_responsible"
+    doc = factory.SubFactory('ietf.doc.factories.BofreqFactory')
+
+
+    @factory.post_generation
+    def responsible(obj, create, extracted, **kwargs):
+        if not create:
+            return
+        if extracted:
+            obj.responsible.set(extracted)
+        else:
+            ad = RoleFactory(group__type_id='area',name_id='ad').person
+            obj.responsible.set([ad])
+        obj.desc = f'Changed responsible leadership to {", ".join(obj.responsible.values_list("name",flat=True)) or "(None)"}'        
+
 class BofreqFactory(BaseDocumentFactory):
     type_id = 'bofreq'
     title = factory.Faker('sentence')
     name = factory.LazyAttribute(lambda o: 'bofreq-%s'%(xslugify(o.title)))
 
     bofreqeditordocevent = factory.RelatedFactory('ietf.doc.factories.BofreqEditorDocEventFactory','doc')
+    bofreqresponsibledocevent = factory.RelatedFactory('ietf.doc.factories.BofreqResponsibleDocEventFactory','doc')
 
     @factory.post_generation
     def states(obj, create, extracted, **kwargs):

ietf/doc/mails.py

@@ -18,8 +18,9 @@
 from ietf.utils import log
 from ietf.utils.mail import send_mail, send_mail_text
 from ietf.ipr.utils import iprs_from_docs, related_docs
-from ietf.doc.models import WriteupDocEvent, LastCallDocEvent, DocAlias, ConsensusDocEvent, BofreqEditorDocEvent
+from ietf.doc.models import WriteupDocEvent, LastCallDocEvent, DocAlias, ConsensusDocEvent
 from ietf.doc.utils import needed_ballot_positions
+from ietf.doc.utils_bofreq import bofreq_editors, bofreq_responsible
 from ietf.group.models import Role
 from ietf.doc.models import Document
 from ietf.mailtrigger.utils import gather_address_lists
@@ -699,14 +700,27 @@ def email_bofreq_title_changed(request, bofreq):
               dict(bofreq=bofreq, request=request),
               cc=addrs.cc)
 
+def plain_names(persons):
+    return [p.plain_name() for p in persons]
+
 def email_bofreq_editors_changed(request, bofreq, previous_editors):
-    editors = bofreq.latest_event(BofreqEditorDocEvent).editors.all()
+    editors = bofreq_editors(bofreq)
     addrs = gather_address_lists('bofreq_editors_changed', doc=bofreq, previous_editors=previous_editors)
 
     send_mail(request, addrs.to, settings.DEFAULT_FROM_EMAIL,
               f'BOF Request editors changed : {bofreq.name}',
               'doc/mail/bofreq_editors_changed.txt',
-              dict(bofreq=bofreq, request=request, editors=editors, previous_editors=previous_editors),
+              dict(bofreq=bofreq, request=request, editors=plain_names(editors), previous_editors=plain_names(previous_editors)),
+              cc=addrs.cc)
+
+def email_bofreq_responsible_changed(request, bofreq, previous_responsible):
+    responsible = bofreq_responsible(bofreq)
+    addrs = gather_address_lists('bofreq_responsible_changed', doc=bofreq, previous_responsible=previous_responsible)
+
+    send_mail(request, addrs.to, settings.DEFAULT_FROM_EMAIL,
+              f'BOF Request responsible leadership changed : {bofreq.name}',
+              'doc/mail/bofreq_responsible_changed.txt',
+              dict(bofreq=bofreq, request=request, responsible=plain_names(responsible), previous_responsible=plain_names(previous_responsible)),
               cc=addrs.cc)
 
 def email_bofreq_new_revision(request, bofreq):

ietf/doc/migrations/0043_bofreq_docevents.py

@@ -0,0 +1,36 @@
+# Generated by Django 2.2.24 on 2021-07-06 13:34
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('person', '0019_auto_20210604_1443'),
+        ('doc', '0042_bofreq_states'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='docevent',
+            name='type',
+            field=models.CharField(choices=[('new_revision', 'Added new revision'), ('new_submission', 'Uploaded new revision'), ('changed_document', 'Changed document metadata'), ('added_comment', 'Added comment'), ('added_message', 'Added message'), ('edited_authors', 'Edited the documents author list'), ('deleted', 'Deleted document'), ('changed_state', 'Changed state'), ('changed_stream', 'Changed document stream'), ('expired_document', 'Expired document'), ('extended_expiry', 'Extended expiry of document'), ('requested_resurrect', 'Requested resurrect'), ('completed_resurrect', 'Completed resurrect'), ('changed_consensus', 'Changed consensus'), ('published_rfc', 'Published RFC'), ('added_suggested_replaces', 'Added suggested replacement relationships'), ('reviewed_suggested_replaces', 'Reviewed suggested replacement relationships'), ('changed_action_holders', 'Changed action holders for document'), ('changed_group', 'Changed group'), ('changed_protocol_writeup', 'Changed protocol writeup'), ('changed_charter_milestone', 'Changed charter milestone'), ('initial_review', 'Set initial review time'), ('changed_review_announcement', 'Changed WG Review text'), ('changed_action_announcement', 'Changed WG Action text'), ('started_iesg_process', 'Started IESG process on document'), ('created_ballot', 'Created ballot'), ('closed_ballot', 'Closed ballot'), ('sent_ballot_announcement', 'Sent ballot announcement'), ('changed_ballot_position', 'Changed ballot position'), ('changed_ballot_approval_text', 'Changed ballot approval text'), ('changed_ballot_writeup_text', 'Changed ballot writeup text'), ('changed_rfc_editor_note_text', 'Changed RFC Editor Note text'), ('changed_last_call_text', 'Changed last call text'), ('requested_last_call', 'Requested last call'), ('sent_last_call', 'Sent last call'), ('scheduled_for_telechat', 'Scheduled for telechat'), ('iesg_approved', 'IESG approved document (no problem)'), ('iesg_disapproved', 'IESG disapproved document (do not publish)'), ('approved_in_minute', 'Approved in minute'), ('iana_review', 'IANA review comment'), ('rfc_in_iana_registry', 'RFC is in IANA registry'), ('rfc_editor_received_announcement', 'Announcement was received by RFC Editor'), ('requested_publication', 'Publication at RFC Editor requested'), ('sync_from_rfc_editor', 'Received updated information from RFC Editor'), ('requested_review', 'Requested review'), ('assigned_review_request', 'Assigned review request'), ('closed_review_request', 'Closed review request'), ('closed_review_assignment', 'Closed review assignment'), ('downref_approved', 'Downref approved'), ('posted_related_ipr', 'Posted related IPR'), ('removed_related_ipr', 'Removed related IPR'), ('changed_editors', 'Changed BOF Request editors')], max_length=50),
+        ),
+        migrations.CreateModel(
+            name='BofreqResponsibleDocEvent',
+            fields=[
+                ('docevent_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='doc.DocEvent')),
+                ('responsible', models.ManyToManyField(blank=True, to='person.Person')),
+            ],
+            bases=('doc.docevent',),
+        ),
+        migrations.CreateModel(
+            name='BofreqEditorDocEvent',
+            fields=[
+                ('docevent_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='doc.DocEvent')),
+                ('editors', models.ManyToManyField(blank=True, to='person.Person')),
+            ],
+            bases=('doc.docevent',),
+        ),
+    ]

ietf/doc/migrations/0043_bofreqeditordocevent.py

@@ -1349,4 +1349,9 @@ class EditedAuthorsDocEvent(DocEvent):
     basis = models.CharField(help_text="What is the source or reasoning for the changes to the author list",max_length=255)
 
 class BofreqEditorDocEvent(DocEvent):
-    editors = models.ManyToManyField('person.Person',blank=True)
+    """ Capture the proponents of a Bof Request."""
+    editors = models.ManyToManyField('person.Person', blank=True)
+
+class BofreqResponsibleDocEvent(DocEvent):
+    """ Capture the responsible leadership (IAB and IESG members) for a BoF Request """
+    responsible = models.ManyToManyField('person.Person', blank=True)

ietf/doc/models.py

@@ -17,7 +17,8 @@
     InitialReviewDocEvent, DocHistoryAuthor, BallotDocEvent, RelatedDocument,
     RelatedDocHistory, BallotPositionDocEvent, AddedMessageEvent, SubmissionDocEvent,
     ReviewRequestDocEvent, ReviewAssignmentDocEvent, EditedAuthorsDocEvent, DocumentURL,
-    IanaExpertDocEvent, IRSGBallotDocEvent, DocExtResource, DocumentActionHolder, BofreqEditorDocEvent)
+    IanaExpertDocEvent, IRSGBallotDocEvent, DocExtResource, DocumentActionHolder, 
+    BofreqEditorDocEvent,BofreqResponsibleDocEvent)
 
 from ietf.name.resources import BallotPositionNameResource, DocTypeNameResource
 class BallotTypeResource(ModelResource):
@@ -832,3 +833,29 @@ class Meta:
             "editors": ALL_WITH_RELATIONS,
         }
 api.doc.register(BofreqEditorDocEventResource())
+
+
+from ietf.person.resources import PersonResource
+class BofreqResponsibleDocEventResource(ModelResource):
+    by               = ToOneField(PersonResource, 'by')
+    doc              = ToOneField(DocumentResource, 'doc')
+    docevent_ptr     = ToOneField(DocEventResource, 'docevent_ptr')
+    responsible      = ToManyField(PersonResource, 'responsible', null=True)
+    class Meta:
+        queryset = BofreqResponsibleDocEvent.objects.all()
+        serializer = api.Serializer()
+        cache = SimpleCache()
+        #resource_name = 'bofreqresponsibledocevent'
+        ordering = ['docevent_ptr', ]
+        filtering = { 
+            "id": ALL,
+            "time": ALL,
+            "type": ALL,
+            "rev": ALL,
+            "desc": ALL,
+            "by": ALL_WITH_RELATIONS,
+            "doc": ALL_WITH_RELATIONS,
+            "docevent_ptr": ALL_WITH_RELATIONS,
+            "responsible": ALL_WITH_RELATIONS,
+        }
+api.doc.register(BofreqResponsibleDocEventResource())