Skip to content

Commit 78a1464

Browse files
author
Sasha Romijn
committed
Ref ietf-tools#2526 - Fix test failure in [16895]
This also makes a small text clarification, which was also the initial reason for the test failure. Commit ready for merge. - Legacy-Id: 16902 Note: SVN reference [16895] has been migrated to Git commit ef1e800
1 parent ef1e800 commit 78a1464

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

ietf/group/tests_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def test_email_open_review_assignments(self):
271271
q = PyQuery(r.content)
272272
generated_text = q("[name=body]").text()
273273
self.assertTrue(review_req1.doc.name in generated_text)
274-
self.assertTrue('(-0 lc review)' in generated_text) # previous completed assignment
274+
self.assertTrue('(-0 lc reviewed)' in generated_text) # previous completed assignment
275275
self.assertTrue(six.text_type(Person.objects.get(user__username="marschairman")) in generated_text)
276276

277277
empty_outbox()

ietf/group/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1609,7 +1609,7 @@ def email_open_review_assignments(request, acronym, group_type=None):
16091609
r.lastcall_ends = e and e.expires.date().isoformat()
16101610
r.earlier_review = ReviewAssignment.objects.filter(review_request__doc=r.review_request.doc,reviewer__in=r.reviewer.person.email_set.all(),state="completed")
16111611
if r.earlier_review:
1612-
earlier_reviews_formatted = ['-{} {} completed'.format(ra.reviewed_rev, ra.review_request.type.slug) for ra in r.earlier_review]
1612+
earlier_reviews_formatted = ['-{} {} reviewed'.format(ra.reviewed_rev, ra.review_request.type.slug) for ra in r.earlier_review]
16131613
r.earlier_reviews = '({})'.format(', '.join(earlier_reviews_formatted))
16141614

16151615
review_assignments.sort(key=lambda r: r.section_order)

0 commit comments

Comments
 (0)