Skip to content

Commit 67e6423

Browse files
committed
Modify importer to pick deadline from documents when there's an exact
match, otherwise prefer what's stored with the review request (fixes a bunch of cases with multiple reviews of the same draft) - Legacy-Id: 12246
1 parent b9d5352 commit 67e6423

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

ietf/review/import_from_review_tool.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -372,14 +372,17 @@ def parse_timestamp(t):
372372
continue # ignore
373373

374374
meta = doc_metadata.get((row.docname, row.version))
375-
if not meta:
376-
meta = doc_metadata.get(row.docname)
377-
378375
deadline, telechat, lcend, status = meta or (None, None, None, None)
379-
380376
if not deadline:
381377
deadline = parse_timestamp(row.timeout)
382378

379+
if not meta:
380+
meta = doc_metadata.get(row.docname)
381+
telechat, lcend, status = (meta or (None, None, None, None))[1:]
382+
383+
if not deadline and meta:
384+
deadline = meta[1]
385+
383386
reviewed_rev = row.version if row.version and row.version != "99" else ""
384387
if row.summary == "noresponse":
385388
reviewed_rev = ""

0 commit comments

Comments
 (0)