Skip to content

Commit 617dac4

Browse files
committed
Send email to reviewer when request is closed with no response. Fixes ietf-tools#2176. Commit ready to merge.
- Legacy-Id: 13897
1 parent 7a11217 commit 617dac4

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

ietf/review/utils.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,6 @@ def reviewer_settings_for(person_id):
504504
def close_review_request(request, review_req, close_state):
505505
suggested_req = review_req.pk is None
506506

507-
prev_state = review_req.state
508507
review_req.state = close_state
509508
if close_state.slug == "no-review-version":
510509
review_req.reviewed_rev = review_req.requested_rev or review_req.doc.rev # save rev for later reference
@@ -522,12 +521,11 @@ def close_review_request(request, review_req, close_state):
522521
state=review_req.state,
523522
)
524523

525-
if prev_state.slug != "requested":
526-
email_review_request_change(
527-
request, review_req,
528-
"Closed review request for {}: {}".format(review_req.doc.name, close_state.name),
529-
"Review request has been closed by {}.".format(request.user.person),
530-
by=request.user.person, notify_secretary=False, notify_reviewer=True, notify_requested_by=True)
524+
email_review_request_change(
525+
request, review_req,
526+
"Closed review request for {}: {}".format(review_req.doc.name, close_state.name),
527+
"Review request has been closed by {}.".format(request.user.person),
528+
by=request.user.person, notify_secretary=False, notify_reviewer=True, notify_requested_by=True)
531529

532530
def suggested_review_requests_for_team(team):
533531

0 commit comments

Comments
 (0)