Skip to content

Commit 54bc9ff

Browse files
committed
Modify importer to close review requests for done documents as status
"Unknown" instead of auto-closing those where the IESG state is further in the process on - this seems to leave more requests in genart open, but hopefully the extra data for genart will fix this problem shortly. - Legacy-Id: 12247
1 parent 67e6423 commit 54bc9ff

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

ietf/review/import_from_review_tool.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,8 @@ def parse_timestamp(t):
189189

190190
# review requests
191191

192+
ReviewRequestStateName.objects.get_or_create(slug="unknown", name="Unknown", order=20, used=False)
193+
192194
states = { n.slug: n for n in ReviewRequestStateName.objects.all() }
193195
# map some names
194196
states["assigned"] = states["requested"]
@@ -676,8 +678,8 @@ def fix_docname(docname):
676678

677679
print "imported review document", review_req.doc, review.name
678680

679-
if review_req.state_id in ("requested", "accepted") and review_req.doc.get_state_slug("draft-iesg") in ["approved", "ann", "rfcqueue", "pub"]:
680-
review_req.state = states["overtaken"]
681+
if review_req.state_id in ("requested", "accepted") and status == "done":
682+
review_req.state = states["unknown"]
681683
review_req.save()
682684

683685
if "closed" not in event_collection and "assigned" in event_collection:
@@ -692,6 +694,6 @@ def fix_docname(docname):
692694
e.save()
693695
completion_event = e
694696
print "imported event closed_review_request (generated upon closing)", e.desc, e.doc_id
695-
697+
696698

697699
print "imported review request", row.reviewid, "as", review_req.pk, review_req.time, review_req.deadline, review_req.type, review_req.doc_id, review_req.state, review_req.doc.get_state_slug("draft-iesg")

0 commit comments

Comments
 (0)