Skip to content

Commit 506dcb3

Browse files
committed
Merged in [16604] from rjsparks@nostrum.com:
Look at all scheduled sessions for a group when deciding to display a cancelled banner. Fixes ietf-tools#2764. - Legacy-Id: 16691 Note: SVN reference [16604] has been migrated to Git commit aea3c1a
1 parent 7ad34ba commit 506dcb3

4 files changed

Lines changed: 7 additions & 2 deletions

File tree

bin/mergeready

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ hold += get_changeset_list_from_file(repo, '../hold-for-merge')
288288
ready += get_ready_commits(repo, 'personal')
289289
ready += get_ready_commits(repo, 'branch/amsl')
290290
ready += get_ready_commits(repo, 'branch/iola')
291+
ready += get_ready_commits(repo, 'branch/dash')
291292
ready += get_ready_commits(repo, 'branch/proceedings')
292293

293294
ready_commits = {}

ietf/meeting/models.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -968,6 +968,10 @@ def all_meeting_sessions_for_group(self):
968968
else:
969969
return [self]
970970

971+
def all_meeting_sessions_cancelled(self):
972+
states = set([s.status_id for s in self.all_meeting_sessions_for_group()])
973+
return 'canceled' in states and len(states) == 1
974+
971975
def all_meeting_recordings(self):
972976
recordings = [] # These are not sets because we need to preserve relative ordering or redo the ordering work later
973977
sessions = self.all_meeting_sessions_for_group()

ietf/templates/meeting/group_materials.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
{% endif %}
1919
</td>
2020

21-
{% if session.status_id == 'canceled' %}
21+
{% if session.all_meeting_sessions_cancelled %}
2222
{% if user|has_role:"Secretariat" or user_groups %}
2323
<td colspan="6"><span class="label label-danger">Session cancelled</span></td>
2424
{% else %}

ietf/templates/meeting/group_proceedings.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
{% endif %}
1919
</td>
2020

21-
{% if session.status_id == 'canceled' %}
21+
{% if session.all_meeting_sessions_cancelled %}
2222
<td colspan="3"><span class="label label-danger">Session cancelled</span></td>
2323
{% else %}
2424
<td>

0 commit comments

Comments
 (0)