Skip to content

Commit 40f4ca4

Browse files
committed
Modified a template to handle old reviews with incomplete information appropriately, instead of leading to 500 errors.
- Legacy-Id: 16186
1 parent 3502a49 commit 40f4ca4

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

ietf/templates/doc/review/request_info.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,13 @@
8181
<th>Completed reviews</th>
8282
<td>
8383
{% for a in review_req.all_completed_assignments_for_doc %}
84-
<a href="{% url "ietf.doc.views_doc.document_main" name=a.review.name %}">{{a.review_request.team.acronym|capfirst}} {{a.review_request.type.name}} review of -{{a.reviewed_rev}} by {{a.reviewer.person.plain_name}}</a> {% if a.reviewed_rev != a.review_request.doc.rev %} (<a href="{{ rfcdiff_base_url }}?url1={{ a.review_request.doc.name }}-{{ a.reviewed_rev }}&amp;url2={{ a.review_request.doc.name }}-{{ a.review_request.doc.rev }}">diff</a>){% endif %}<br>
84+
{% if a.review %}
85+
<a href="{% url "ietf.doc.views_doc.document_main" name=a.review.name %}">{{a.review_request.team.acronym|capfirst}} {{a.review_request.type.name}} review of -{{a.reviewed_rev|default:"??"}} by {{a.reviewer.person.plain_name}}</a>
86+
{% else %}
87+
{{a.review_request.team.acronym|capfirst}} {{a.review_request.type.name}} review of -{{a.reviewed_rev|default:"??"}} by {{a.reviewer.person.plain_name}}
88+
{% endif %}
89+
{% if a.reviewed_rev and a.reviewed_rev != a.review_request.doc.rev %} (<a href="{{ rfcdiff_base_url }}?url1={{ a.review_request.doc.name }}-{{ a.reviewed_rev }}&amp;url2={{ a.review_request.doc.name }}-{{ a.review_request.doc.rev }}">diff</a>){% endif %}
90+
<br>
8591
{% endfor %}
8692
</td>
8793
</tr>

0 commit comments

Comments
 (0)