Skip to content

Commit 3502a49

Browse files
committed
Fixed a problem in 3 views that were accessible through URLs without meeting numbers (e.g., .../meeting/proceedings/overview/) but gave 500 errors when accessed.
- Legacy-Id: 16185
1 parent 9d55620 commit 3502a49

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

ietf/meeting/views.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2189,9 +2189,9 @@ def finalize_proceedings(request, num=None):
21892189

21902190
def proceedings_acknowledgements(request, num=None):
21912191
'''Display Acknowledgements for meeting'''
2192-
meeting = get_meeting(num)
2193-
if not num.isdigit():
2192+
if not (num and num.isdigit()):
21942193
raise Http404
2194+
meeting = get_meeting(num)
21952195
if int(meeting.number) < settings.NEW_PROCEEDINGS_START:
21962196
return HttpResponseRedirect( 'https://www.ietf.org/proceedings/%s/acknowledgement.html' % num )
21972197
return render(request, "meeting/proceedings_acknowledgements.html", {
@@ -2200,9 +2200,9 @@ def proceedings_acknowledgements(request, num=None):
22002200

22012201
def proceedings_attendees(request, num=None):
22022202
'''Display list of meeting attendees'''
2203-
meeting = get_meeting(num)
2204-
if not num.isdigit():
2203+
if not (num and num.isdigit()):
22052204
raise Http404
2205+
meeting = get_meeting(num)
22062206
if int(meeting.number) < settings.NEW_PROCEEDINGS_START:
22072207
return HttpResponseRedirect( 'https://www.ietf.org/proceedings/%s/attendees.html' % num )
22082208
overview_template = '/meeting/proceedings/%s/attendees.html' % meeting.number
@@ -2217,9 +2217,9 @@ def proceedings_attendees(request, num=None):
22172217

22182218
def proceedings_overview(request, num=None):
22192219
'''Display Overview for given meeting'''
2220-
meeting = get_meeting(num)
2221-
if not num.isdigit():
2220+
if not (num and num.isdigit()):
22222221
raise Http404
2222+
meeting = get_meeting(num)
22232223
if int(meeting.number) < settings.NEW_PROCEEDINGS_START:
22242224
return HttpResponseRedirect( 'https://www.ietf.org/proceedings/%s/overview.html' % num )
22252225
overview_template = '/meeting/proceedings/%s/overview.rst' % meeting.number
@@ -2235,9 +2235,9 @@ def proceedings_overview(request, num=None):
22352235
@cache_page( 60 * 60 )
22362236
def proceedings_progress_report(request, num=None):
22372237
'''Display Progress Report (stats since last meeting)'''
2238-
meeting = get_meeting(num)
2239-
if not num.isdigit():
2238+
if not (num and num.isdigit()):
22402239
raise Http404
2240+
meeting = get_meeting(num)
22412241
if int(meeting.number) < settings.NEW_PROCEEDINGS_START:
22422242
return HttpResponseRedirect( 'https://www.ietf.org/proceedings/%s/progress-report.html' % num )
22432243
sdate = meeting.previous_meeting().date

0 commit comments

Comments
 (0)