Skip to content

Commit 35a2a14

Browse files
committed
Merged in [17708] from rjsparks@nostrum.com:
Remove 'point raised - writup needed' from the set of substates the IESG can use with a document. Fixes ietf-tools#2968. - Legacy-Id: 17731 Note: SVN reference [17708] has been migrated to Git commit fa492c3
2 parents 85f3971 + fa492c3 commit 35a2a14

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

ietf/doc/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class Meta:
7474
ordering = ["type", "order"]
7575

7676
IESG_BALLOT_ACTIVE_STATES = ("lc", "writeupw", "goaheadw", "iesg-eva", "defer")
77-
IESG_SUBSTATE_TAGS = ('point', 'ad-f-up', 'need-rev', 'extpty')
77+
IESG_SUBSTATE_TAGS = ('ad-f-up', 'need-rev', 'extpty')
7878

7979
class DocumentInfo(models.Model):
8080
"""Any kind of document. Draft, RFC, Charter, IPR Statement, Liaison Statement"""

ietf/doc/tests_draft.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def test_ad_approved(self):
4040
ad = Person.objects.get(user__username="ad")
4141
draft = WgDraftFactory(ad=ad,states=[('draft','active'),('draft-iesg','iesg-eva')])
4242
DocEventFactory(type='started_iesg_process',by=ad,doc=draft,rev=draft.rev,desc="Started IESG Process")
43-
draft.tags.add("point")
43+
draft.tags.add("ad-f-up")
4444

4545
url = urlreverse('ietf.doc.views_draft.change_state', kwargs=dict(name=draft.name))
4646
login_testing_unauthorized(self, "ad", url)
@@ -114,14 +114,14 @@ def test_change_state(self):
114114

115115
r = self.client.post(url,
116116
dict(state=State.objects.get(used=True, type="draft-iesg", slug="review-e").pk,
117-
substate="point",
117+
substate="need-rev",
118118
comment="Test comment"))
119119
self.assertEqual(r.status_code, 302)
120120

121121
draft = Document.objects.get(name=draft.name)
122122
self.assertEqual(draft.get_state_slug("draft-iesg"), "review-e")
123123
self.assertTrue(not draft.tags.filter(slug="ad-f-up"))
124-
self.assertTrue(draft.tags.filter(slug="point"))
124+
self.assertTrue(draft.tags.filter(slug="need-rev"))
125125
self.assertEqual(draft.docevent_set.count(), events_before + 2)
126126
self.assertTrue("Test comment" in draft.docevent_set.all()[0].desc)
127127
self.assertTrue("IESG state changed" in draft.docevent_set.all()[1].desc)

ietf/secr/telechat/forms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# Globals
1111
# -------------------------------------------------
1212

13-
TELECHAT_TAGS = ('point','ad-f-up','extpty','need-rev')
13+
TELECHAT_TAGS = ('ad-f-up','extpty','need-rev')
1414

1515
# -------------------------------------------------
1616
# Forms

0 commit comments

Comments
 (0)