Skip to content

Commit 3245678

Browse files
authored
fix: Hide tooltips after review wish icon is clicked (ietf-tools#3799)
Similar how it's done with the track/untrack icon. Also remove duplicate javascript for this functionality.
1 parent 19e639f commit 3245678

2 files changed

Lines changed: 4 additions & 34 deletions

File tree

ietf/static/js/doc-search.js

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -76,35 +76,4 @@ $(document)
7676

7777
updateAdvanced();
7878
}
79-
80-
$(".review-wish-add-remove-doc.ajax, .track-untrack-doc")
81-
.on("click", function (e) {
82-
e.preventDefault();
83-
var trigger = $(this);
84-
$.ajax({
85-
url: trigger.attr("href"),
86-
type: "POST",
87-
cache: false,
88-
dataType: "json",
89-
success: function (response) {
90-
if (response.success) {
91-
trigger.parent()
92-
.find(".tooltip")
93-
.remove();
94-
trigger.attr("hidden", true);
95-
96-
var target_unhide = null;
97-
if (trigger.hasClass("review-wish-add-remove-doc")) {
98-
target_unhide = ".review-wish-add-remove-doc";
99-
} else if (trigger.hasClass("track-untrack-doc")) {
100-
target_unhide = ".track-untrack-doc";
101-
}
102-
trigger.parent()
103-
.find(target_unhide)
104-
.not(trigger)
105-
.removeAttr("hidden");
106-
}
107-
}
108-
});
109-
});
110-
});
79+
});

ietf/static/js/ietf.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,9 @@ $(document)
274274
dataType: 'json',
275275
success: function (response) {
276276
if (response.success) {
277+
// hide tooltip after clicking icon
277278
trigger.parent()
278-
.find(".track-untrack-doc")
279+
.find(".review-wish-add-remove-doc.ajax, .track-untrack-doc")
279280
.tooltip("hide");
280281
trigger.addClass("d-none");
281282

@@ -331,4 +332,4 @@ $(document)
331332
.siblings(".full")
332333
.removeClass("d-none");
333334
});
334-
});
335+
});

0 commit comments

Comments
 (0)